Do not drop the data field in decapsulate
#3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
the
improvement
dominiklohmann
force-pushed
the
topic/decapsulate-keep-data
branch
4 times, most recently
from
8983658
to
2d7ba09
Compare
mavam
force-pushed
the
topic/decapsulate-keep-data
branch
from
2d7ba09
to
e1841f1
Compare
mavam
reviewed
Sep 16, 2023
This changes the `decapsulate` operator to keep the `data` field in its incoming packet events that rather than dropping it. It does so without copying the data.
mavam
force-pushed
the
topic/decapsulate-keep-data
branch
from
e1841f1
to
ebcf479
Compare
mavam
force-pushed
the
topic/decapsulate-keep-data
branch
from
8330237
to
981b70a
Compare
mavam
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
@dominiklohmann mind glossing over the code just briefly? I especially the refactoring of the PCAP saver could use another pair of eyes.
This also silences clang-tidy, which rightfully complained about the missing continue statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
decapsulateoperator to keep thedatafield in its incoming packet events that rather than dropping it. It does so without copying the data.