Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8314: Add debug guide in CONTRIBUTING.md #8385

Merged
merged 1 commit into from May 14, 2024
Merged

Conversation

tt-dma
Copy link
Contributor

@tt-dma tt-dma commented May 11, 2024

Thought here is to have a reasonable debugging guide people can go through before filing issues, in a more front-and-centre place than the docs.

Updated the old debugging tips section here: https://github.com/tenstorrent/tt-metal/blob/dma/8314_debug_guide/CONTRIBUTING.md#debugging-guide

Let me know if anything looks unclear/should be changed, or if anything big is missing. Also can move this write-up to a different section, but just left it where it was before - let me know if we want it somewhere else

@tt-dma tt-dma requested review from davorchap and pgkeller May 11, 2024 01:01
@tt-dma tt-dma requested a review from tt-rkim as a code owner May 11, 2024 01:01
Copy link
Collaborator

@davorchap davorchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great.

In the device hang section , perhaps make two subsection , 1) watcher , 2) watcher dump tool

@tt-dma
Copy link
Contributor Author

tt-dma commented May 13, 2024

It's great.

In the device hang section , perhaps make two subsection , 1) watcher , 2) watcher dump tool

Added this!

@tt-dma tt-dma force-pushed the dma/8314_debug_guide branch 2 times, most recently from f009eb9 to e83a8f3 Compare May 14, 2024 17:19
@tt-dma tt-dma merged commit cc553ab into main May 14, 2024
5 checks passed
@tt-dma tt-dma deleted the dma/8314_debug_guide branch May 14, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants