Add grouped convolution support #8341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapspatel
requested review from
tt-nshanker,
eyonland,
arakhmati,
cfjchu,
xanderchin,
TT-BrianLiu,
tt-aho and
mywoodstock
as code owners
|
Issue: #8340 |
|
@tapspatel I think we should wait a couple days -- to get the new c++ convs in and then update this PR to use the new version. |
tapspatel
force-pushed
the
tpatel/issue-8340
branch
from
e400e99
to
49554c7
Compare
TT-BrianLiu
reviewed
May 24, 2024
Comment on lines
+884
to
+900
| m_tensor.def( | ||
| "convert_conv_weight_tensor_to_grouped_layout", | ||
| &convert_conv_weight_tensor_to_grouped_layout, | ||
| py::arg("conv_weight_tensor").noconvert(), | ||
| py::arg("num_groups"), | ||
| py::arg("output_dtype").noconvert() = std::nullopt, | ||
| R"doc( | ||
| Converts convolution weights to grouped layout with padded zeros | ||
| Returns a new tensor with the converted layout. | ||
|
|
||
| +----------+----------------------+-----------+-------------+----------+ | ||
| | Argument | Description | Data type | Valid range | Required | | ||
| +==========+======================+===========+=============+==========+ | ||
| | a | Input tensor | Tensor | | Yes | | ||
| +----------+----------------------+-----------+-------------+----------+ | ||
| )doc"); | ||
|
|
There was a problem hiding this comment.
I think we should eventually move these bindings to a lower level module that's not just ttl.tensor.*.
TT-BrianLiu
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.