-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for watcher noc sanitization in noc_nonblocking_api.h #8334
Conversation
ccf6ca3
to
4a4d1d1
Compare
One bugfix, new CI here: https://github.com/tenstorrent/tt-metal/actions/runs/9024995737 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The noc checking was done at the dataflow layer because these noc layer are routines that may be shared w/ buda at some point. Please ping Milos on his plans before pushing this down to that layer. Otherwise, I'm ok w/ this.
Conclusion per Milos is to leave Metal-specific things out of I've added in the missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be sure to squash these commits so we don't have the changes in noc_* file histories
587f806
to
55e63bc
Compare
Had to do a bit of cleanup/rearranging in the headers to get around some circular dependencies + multiple definitions, let me know if anything looks off.
Passing CI: https://github.com/tenstorrent/tt-metal/actions/runs/9024330478