New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5773: Move SD model to demo folder #8294
base: main
Are you sure you want to change the base?
Conversation
This is a type, the model was correctly moved to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run nightly and post a passing link for your branch
@@ -12,6 +12,26 @@ echo "Running nightly tests for WH B0 only" | |||
env pytest tests/ttnn/integration_tests/unet # -> failing: issue #7556 | |||
SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml env pytest tests/ttnn/integration_tests/stable_diffusion | |||
|
|||
env pytest tests/ttnn/integration_tests/stable_diffusion/test_basic_transformer_block.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there tests in this folder that cannot be run in nightly, ex. perf, device perf etc? Is this why you list so many?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to check these tests in the Nightly, that's why I have added all the tests here.
env pytest tests/ttnn/integration_tests/stable_diffusion/test_unet_mid_block_2d_cross_attn.py | ||
env pytest tests/ttnn/integration_tests/stable_diffusion/test_upblock_2d.py | ||
env pytest tests/ttnn/integration_tests/stable_diffusion/test_upsample_2d.py | ||
env pytest tests/ttnn/integration_tests/stable_diffusion/test_upsample_nearest_2d.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests will need to be run with env vars:
SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AleksKnezevic, will add these environment variables. Would it be enough to add the test in a single line? like
SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml env pytest tests/ttnn/integration_tests/stable_diffusion/tests/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, that's fine. I believe there's already a SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml env pytest tests/ttnn/integration_tests/stable_diffusion
line just above these additions
989a314
to
74d581c
Compare
This seems like a significant regression on WH on-device SD:
@AleksKnezevic should we instruct @Sudharsan-V to investigate? |
This PR has the following:
models/demos/wormhole/
folder.