Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5773: Move SD model to demo folder #8294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sudharsan-V
Copy link
Contributor

@Sudharsan-V Sudharsan-V commented May 9, 2024

This PR has the following:

  • Moved SD to models/demos/wormhole/ folder.
  • Added the SD tests to run_wh_b0_only.sh

@AleksKnezevic
Copy link
Contributor

This PR has the following:

  • Moved SD to models/demos/grayskull/ folder.
  • Added the SD tests to run_wh_b0_only.sh

This is a type, the model was correctly moved to models/demos/wormhole/ in PR.

Copy link
Collaborator

@tt-rkim tt-rkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run nightly and post a passing link for your branch

@@ -12,6 +12,26 @@ echo "Running nightly tests for WH B0 only"
env pytest tests/ttnn/integration_tests/unet # -> failing: issue #7556
SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml env pytest tests/ttnn/integration_tests/stable_diffusion

env pytest tests/ttnn/integration_tests/stable_diffusion/test_basic_transformer_block.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests in this folder that cannot be run in nightly, ex. perf, device perf etc? Is this why you list so many?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to check these tests in the Nightly, that's why I have added all the tests here.

env pytest tests/ttnn/integration_tests/stable_diffusion/test_unet_mid_block_2d_cross_attn.py
env pytest tests/ttnn/integration_tests/stable_diffusion/test_upblock_2d.py
env pytest tests/ttnn/integration_tests/stable_diffusion/test_upsample_2d.py
env pytest tests/ttnn/integration_tests/stable_diffusion/test_upsample_nearest_2d.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests will need to be run with env vars:
SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AleksKnezevic, will add these environment variables. Would it be enough to add the test in a single line? like
SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml env pytest tests/ttnn/integration_tests/stable_diffusion/tests/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's fine. I believe there's already a SLOW_MATMULS=1 WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml env pytest tests/ttnn/integration_tests/stable_diffusion line just above these additions

@tt-rkim
Copy link
Collaborator

tt-rkim commented May 22, 2024

This seems like a significant regression on WH on-device SD:

AssertionError: Some model(s) AVG DEVICE KERNEL SAMPLES/S are too slow, see above for details. {'AVG DEVICE KERNEL SAMPLES/S': [('stable_diffusion_1batch_', 8.2062, 9.7911)]}

@AleksKnezevic should we instruct @Sudharsan-V to investigate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants