hwmon: add ETH support for N300 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olofj
reviewed
Feb 27, 2024
|
Sorry, I'm going to go back on something I said earlier. I said that we shouldn't use the fact that BAR4 happens to cover the kernel driver's TLB. But BAR0 can be reduced below 512MB in some systems, so BAR4 is the only assured way to access that TLB. Could you please use BAR4 instead? Conveniently, the last TLB is located at offset 0 in BAR 4. |
joelsmithTT
force-pushed
the
joelsmith/wh-eth2
branch
from
ab0ed93
to
69c3408
Compare
olofj
reviewed
Feb 28, 2024
alewycky-tenstorrent
requested changes
Feb 28, 2024
joelsmithTT
force-pushed
the
joelsmith/wh-eth2
branch
from
69c3408
to
d621d7f
Compare
joelsmithTT
commented
Feb 28, 2024
joelsmithTT
force-pushed
the
joelsmith/wh-eth2
branch
from
957eab4
to
25fc16c
Compare
olofj
reviewed
Mar 7, 2024
An upcoming change for Metal will require remote transfers to use a connected ETH core.
joelsmithTT
force-pushed
the
joelsmith/wh-eth2
branch
3 times, most recently
from
1e37425
to
5890df3
Compare
Problem: ETH core request and response queues can not be shared between processes without synchronization, and KMD uses an ETH core in its hwmon code path for N300 devices. Although KMD exposes a locking API, userspace is free to interact with ETH cores without using this API. Workaround: track whether processes with an open device have used the locking API. If all such processes have used it, assume they are using it correctly. If any such process has not used it, assume that we can not access an ETH core safely and return -EBUSY in the code path for reading telemetry from the remote chip on an N300 board.
joelsmithTT
force-pushed
the
joelsmith/wh-eth2
branch
from
5890df3
to
6005e35
Compare
alewycky-tenstorrent
approved these changes
Mar 8, 2024
|
If I manually merge this with master, it runs CI and the CI passes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.