Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix that recent changes broke the MSVC build of tflite-c #68233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NoiseEHC
Copy link

otherwise MSVC says error C7555: use of designated initializers requires at least '/std:c++20'
for example "new TfLiteOperator{.custom_name = ..." does not compile

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label May 19, 2024
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TF is not yet C++20 ready. This should probably still stay on C++17

@NoiseEHC
Copy link
Author

TF is not yet C++20 ready. This should probably still stay on C++17

Then you have to revert all uses of C++20 struct initialization. It is also used in some of the dependencies too.

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation May 20, 2024
@gbaned gbaned added the comp:lite TF Lite related issues label May 20, 2024
@gbaned gbaned added the awaiting review Pull request awaiting review label Jun 7, 2024
@gbaned gbaned requested a review from junjiang-lab June 7, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review comp:lite TF Lite related issues size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

3 participants