[pjrt] NFC: Always use concrete async value in PjRtFuture<T> #66548
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_628466634
branch
from
101947c
to
7bb6eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pjrt] NFC: Always use concrete async value in PjRtFuture
We plan to make absl::StatusOr an implicit payload of PjRtFuture and for consistency always use AsyncValueRef with concrete payload instead of relying on AsyncValue error semantics.
PjRtFuture can't be constructed from async values passed from a user (only from a promise) so we can safely ignore the error bit as we never use it.
This is a first CL in preparation for making absl::StatusOr implicit in PjRtFuture.