Implement sampled addmm #62750
Merged
Implement sampled addmm #62750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattbahr
commented
Jan 7, 2024
mattbahr
commented
Jan 7, 2024
|
Hi @mattbahr Can you please check @cantonios's comments and keep us posted ? Thank you! |
gbaned
added
stat:awaiting response
|
@gbaned absolutely! |
google-ml-butler
bot
removed
the
stat:awaiting response
…ated attribute calls with tf functions
|
😭😭😭😭😭
…On Sat, Jan 27, 2024, 1:39 AM Matt Bahr ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tensorflow/python/ops/math_ops.py
<#62750 (comment)>
:
> + mat1 = ops.convert_to_tensor(mat1)
+ if not isinstance(mat2, tensor_lib.Tensor):
+ mat2 = ops.convert_to_tensor(mat2)
+
+ if values.dtype != output_type:
+ values = cast(values, output_type)
+ if mat1.dtype != output_type:
+ mat1 = cast(mat1, output_type)
+ if mat2.dtype != output_type:
+ mat2 = cast(mat2, output_type)
+
+ dense_rows = mat1.shape[-2]
+ dense_cols = mat2.shape[-1]
+
+ # TODO(mattbahr): use dense_shape to validate the shapes of mat1 and mat2
+ dense_shape = constant_op.constant([dense_rows, dense_cols])
Importing check_ops introduces a circular dependency. I tried using a
regular assert, but I kept getting AssertionErrors when I run my unit
tests.
—
Reply to this email directly, view it on GitHub
<#62750 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5CIWVH2QNOI4J7IY4FRHPTYQSOJTAVCNFSM6AAAAABBQB7C26VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBWHA4TINBQGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
google-ml-butler
bot
removed
the
stat:awaiting response
|
@cantonios When you get the chance, you mind taking a look at my solution for the dense shape validation? Appreciate it! |
gbaned
added
ready to pull
cantonios
approved these changes
Apr 29, 2024
google-ml-butler
bot
added
kokoro:force-run
Merged
copybara-service
bot
merged commit 0d88583
into
tensorflow:master
10 of 12 checks passed
copybara-service bot
pushed a commit
that referenced
this pull request
May 2, 2024
The custom call partitioner registration is not thread-safe. This can lead to a race condition when multiple threads try to register the same partitioner. This CL fixes the race condition by adding a mutex to protect the registration process. FUTURE_COPYBARA_INTEGRATE_REVIEW=#62750 from mattbahr:implement-sampled-addmm-v2 c295a0e PiperOrigin-RevId: 630156374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #56311