Fixed saver relative paths for latest_checkpoint
#573
Closed
+88
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Let me try kicking off the test for this PR by saying some magic words |
|
test this please |
|
Looks generally fine, assigning to Sherry, the original reviewer. |
|
@tensorflow-jenkins, test this please. |
|
(Can you squash the commits if the tests are all passing?) |
This would be cleaner if we made all paths listed in the "latest" file relative to the its directory, allowing the removal of the added `os.path.isabs` checks. That would make the `os.join` in `saver.latest_checkpoint` much less surprising. But at least this way, there is no effect on currently working code. Fixes #571 Change-Id: I47d8536b9b2ed3dcc193d6e6b7f4573a4e22c9b3
|
Done. Rebased on master. |
|
@tensorflow-jenkins, test this please. |
vrv
pushed a commit
that referenced
this pull request
Jan 8, 2016
|
Merged (trying a new workflow where I merge manually via rebasing rather than clicking the button for a better history). |
darkbuck
pushed a commit
to darkbuck/tensorflow
that referenced
this pull request
Jan 23, 2020
…pstream-zyin-fix-cuda-xla-linker-error [XLA:GPU] Reverting cuda->gpu symbol change in cuda runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be cleaner if we made all paths listed in the "latest"
file relative to the its directory, allowing the removal of the
added
os.path.isabschecks.That would make the
os.joininsaver.latest_checkpointmuch lesssurprising.
But at least this way, there is no effect on currently working code.
Fixes #571
Change-Id: I47d8536b9b2ed3dcc193d6e6b7f4573a4e22c9b3