Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to upgrade gast to 0.4.0 #46039

Closed
wants to merge 4 commits into from
Closed

Conversation

bhack
Copy link
Contributor

@bhack bhack commented Dec 29, 2020

No description provided.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Dec 29, 2020
@google-cla google-cla bot added the cla: yes label Dec 29, 2020
@kkimdev kkimdev added the kokoro:force-run Tests on submitted change label Dec 29, 2020
@google-ml-butler google-ml-butler bot added the ready to pull PR ready for merge process label Dec 29, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 29, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Dec 29, 2020
Copy link

@mdanatg mdanatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change. Unfortunately, there are a few internal dependencies that need to be updated in the same PR, and those can only be touched by an internal change. We have everything set up and just need one last approval before pushing it, so this should be resolved soon. It's an unfortunate shortcoming that internal pending changes are not visible externally to avoid this kind of confusion. I'll make a note of the PR in the internal one so that you can get credit for the work.

@bhack
Copy link
Contributor Author

bhack commented Dec 29, 2020

It's an unfortunate shortcoming that internal pending changes are not visible externally to avoid this kind of confusion

@mdanatg Yes you are totally right but I've tried to open a discussion about this big topic since 2016 and we are still here after 4 years with the same problem 😞 . You can see the original 2016 thread at #162 (comment)

@bhack
Copy link
Contributor Author

bhack commented Dec 29, 2020

@mdanatg I am closing this and stop to push other local commits on this upgrade. But how can solve this more in general? Could you start to use ticket with a special label? Where can we track this discussion?

@bhack bhack closed this Dec 29, 2020
@bhack bhack deleted the gast_0.4.0 branch December 29, 2020 14:25
@mdanatg
Copy link

mdanatg commented Dec 29, 2020

@bhack We can use #44485 to continue the discussion, since it's been mentioned there, or alternatively we can open a separate issue to track the 0.4 upgrade alone. In hindsight, we probably should have done that from the beginning.

@bhack
Copy link
Contributor Author

bhack commented Dec 29, 2020

@mdanatg I meant more about where we could discuss the general topic since 2016 so the production of regular public info about in progress internal activities as internal teams commits don't pass through PR/Draft PR pipelines.

@mdanatg
Copy link

mdanatg commented Dec 29, 2020

Ah, let's file a new issue for that part, because it's an important topic and I don't know if one exists.

@bhack bhack mentioned this pull request Dec 29, 2020
@bhack
Copy link
Contributor Author

bhack commented Dec 29, 2020

Ah, let's file a new issue for that part, because it's an important topic and I don't know if one exists.

As we don't have a special place to discuss this kind of topics I've recycled my community ticket at tensorflow/community#29. @mdanatg as @martinwicke is probably no more involved please mention someone else in the team that can discuss/handle this topic.

Thanks

@mdanatg
Copy link

mdanatg commented Dec 29, 2020

SG thanks! It might be worth creating a dedicated ticket as well, to that readers don't mistakenly think this is just about email notifications.

@bhack
Copy link
Contributor Author

bhack commented Dec 29, 2020

@mdanatg I am on hold in the first ticket since 2016 and on that one since 2018 so as you know better the internal dynamics of the team please help me to push this forward.

@mdanatg
Copy link

mdanatg commented Dec 29, 2020

Hmm, since the tickets are so old it's possible they slipped through the cracks; re-filing might help with that. @ewilderj any advice on how to best proceed?

copybara-service bot pushed a commit that referenced this pull request Jan 6, 2021
With thanks to @bhack for contributions in #46039.

PiperOrigin-RevId: 350377724
Change-Id: If1dbc77b9c2c7d640720f847292586aca39da80d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants