Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StringLower/StringUpper op to support lower/upper() for string operations #25859

Merged
merged 10 commits into from
May 3, 2019
Merged

Add StringLower/StringUpper op to support lower/upper() for string operations #25859

merged 10 commits into from
May 3, 2019

Commits on Apr 3, 2019

  1. Add StringLower op to support lower() for string operations 

    This fix tries to address the issue raised in 25857 where
there is no lower() for string operations yet.

This fix adds StringLower to the kernel to support this op.

This fix fixes 25857.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    f00ca97 View commit details
    Browse the repository at this point in the history

  2. Expose strings.lower api endpoint based on StringLower op 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    a19e835 View commit details
    Browse the repository at this point in the history

  3. Add test case for strings.lower op 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    e0a90f8 View commit details
    Browse the repository at this point in the history

  4. Add StringUpper op to support upper() for string operations 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    5781625 View commit details
    Browse the repository at this point in the history

  5. Add test case for strings.upper 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    7cf89bd View commit details
    Browse the repository at this point in the history

  6. Update API compatibility with 

    bazel-bin/tensorflow/tools/api/tests/api_compatibility_test
           --update_goldens True

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    e2da5fd View commit details
    Browse the repository at this point in the history

  7. Add API defs with tensorflow/core/api_def/update_api_def.sh 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    5ebe920 View commit details
    Browse the repository at this point in the history

  8. Add unicode support of strings.lower and strings.upper 

    with additional encoding='' support, utf-8 is supported at the moment

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    b102e32 View commit details
    Browse the repository at this point in the history

  9. Update api golden 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    92828cb View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Fix python 3 test failures caused by unicode string. 

    Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Apr 26, 2019
    Configuration menu
    Copy the full SHA
    fda502e View commit details
    Browse the repository at this point in the history