[Global Pins] Saves all currently pinned cards if the user has enabled global pins. #6848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roseayeon
changed the title
hoonji
approved these changes
May 8, 2024
| this.savedPinsDataSource.removeAllScalarPins(); | ||
| tap(([, pinnedCards, , , getMetricsSavingPinsEnabled]) => { | ||
| if (getMetricsSavingPinsEnabled) { | ||
| const tags = pinnedCards |
There was a problem hiding this comment.
nit: type assertions (...as Tag[]) are unsafe and (in principle) can cause runtime crashes.
Can you try: const tags: Tag[] = .... You may also need to type the filter function callback: filter((v): v is Tag => v !== null)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Feature request during the teamfood:
Clicking disable pins -> pinning a card -> clicking enable pinsdoesn't save the currently pinned card. It seems reasonable to save all currently pinned cards when the setting is activated.This PR saves all currently pinned cards when user clicks enable global pins.
Technical description of changes
97c6324 Added
saveScalarPinsto the data sourcec6be93b Modified
addOrRemovePinsOnTogglelogic to include adding pins logicScreenshots of UI changes (or N/A)
N/A
Detailed steps to verify changes work correctly (as executed by you)
Unit test passes
Alternate designs / implementations considered (or N/A)
N/A