Group colours by regex of the experiment name (UI). #6847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is failing now. Have you confirmed that TAP presubmit has passed? Oh I think |
hoonji
requested changes
May 8, 2024
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_component.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog.ng.html
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.ng.html
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog.ng.html
Outdated
Show resolved
Hide resolved
|
Now the only part left is to make a commit for feature flag. I will try to make it in this PR as well. |
roseayeon
reviewed
May 14, 2024
roseayeon
reviewed
May 14, 2024
tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.ts
Outdated
Show resolved
Hide resolved
hoonji
requested changes
May 14, 2024
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_component.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_component.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.ts
Outdated
Show resolved
Hide resolved
AnuarTB
force-pushed
the
regex_feature_1
branch
2 times, most recently
from
927c819
to
e9d038a
Compare
hoonji
reviewed
May 17, 2024
tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_container.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.ts
Outdated
Show resolved
Hide resolved
tensorboard/webapp/runs/views/runs_table/regex_edit_dialog_container.ts
Outdated
Show resolved
Hide resolved
hoonji
requested changes
May 17, 2024
roseayeon
approved these changes
May 17, 2024
hoonji
approved these changes
May 19, 2024
AnuarTB
pushed a commit
that referenced
this pull request
May 21, 2024
This was missing when #6847 was merged, but it's causing some build errors in internal repo due to more strict dependency checks (this target is currently used via transitive dependencies).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is a continuation of #6846.
Motivation for features / changes
Users want to color runs by the regex string of the corresponding to runs experiment names.
Technical description of changes
Screenshots of UI changes (or N/A)
N/A since internal change.
Detailed steps to verify changes work correctly (as executed by you)
Regex.Experiment Namein dropdown.Alternate designs / implementations considered (or N/A)
N/A