Factor gRPC orchestration modules out of uploader.py #4880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
uploader.py contains many subclasses designed to organize the batching and timing of requests. The goal of this PR is to move them into their own individual modules, in preparation for adding asynchronous functionality to tensorboard uploader.
Technical description of changes
Moves the following independent classes into their own files under a new
orchestration
subdirectory. Adds some tests where in some cases unit testing was sparse.BatchedRequestSender
BlobRequestSender
ByteBudgetManager
ScalarBatchedRequestSender
TensorBatchedRequestSender
Detailed steps to verify changes work correctly (as executed by you)
Beyond unit tests:
and verified that the demo contains the right timeseries, graphs, etc.