Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor gRPC orchestration modules out of uploader.py #4880

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

bileschi
Copy link
Collaborator

@bileschi bileschi commented Apr 16, 2021

  • Motivation for features / changes
    uploader.py contains many subclasses designed to organize the batching and timing of requests. The goal of this PR is to move them into their own individual modules, in preparation for adding asynchronous functionality to tensorboard uploader.

  • Technical description of changes
    Moves the following independent classes into their own files under a new orchestration subdirectory. Adds some tests where in some cases unit testing was sparse.

    • BatchedRequestSender
    • BlobRequestSender
    • ByteBudgetManager
    • ScalarBatchedRequestSender
    • TensorBatchedRequestSender
  • Detailed steps to verify changes work correctly (as executed by you)
    Beyond unit tests:

$ bazel run tensorboard:tensorboard -- dev upload --logdir ~/tensorboard-logdirs/demo/

and verified that the demo contains the right timeseries, graphs, etc.

  • Alternate designs / implementations considered

@google-cla google-cla bot added the cla: yes label Apr 16, 2021
@bileschi bileschi marked this pull request as draft April 16, 2021 22:18
@bileschi bileschi force-pushed the factor_out_batched_request_senders branch from 954f51f to ce24d3d Compare April 19, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant