Add PgUp, PgDn, and Select All buttons #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new Up and Dn buttons just send PageUp and PageDn keycodes to the browser, They make page navigation easier vs. clicking on the scrollbar. The All button sends Ctrl + A to the browser which is helpful when you want to erase previously typed contents of a textbox and put something else. |
|
LGTM but please also add something to README.md - there is a section with description of what the buttons do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These originally were useful additions I made to my local WRP fork. I think they should be in the main version. My local WRP fork is radically different from vanilla WRP so I just backported these new buttons.
