Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the logic to determine if the pool was depleted #369

Merged
merged 4 commits into from Jun 3, 2021

Conversation

hallazzang
Copy link
Contributor

Description

closes: #364


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang hallazzang added the bug Something isn't working label May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #369 (096a0a0) into develop (d1c90aa) will increase coverage by 0.03%.
The diff coverage is 82.60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #369      +/-   ##
===========================================
+ Coverage    83.01%   83.05%   +0.03%     
===========================================
  Files           20       20              
  Lines         2249     2254       +5     
===========================================
+ Hits          1867     1872       +5     
  Misses         209      209              
  Partials       173      173              
Impacted Files Coverage Δ
x/liquidity/keeper/liquidity_pool.go 79.59% <80.95%> (+0.15%) ⬆️
x/liquidity/keeper/swap.go 81.53% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c90aa...096a0a0. Read the comment docs.

@hallazzang hallazzang marked this pull request as ready for review May 28, 2021 05:18
@hallazzang hallazzang self-assigned this May 28, 2021
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hallazzang

Could you revert the changes about QuoTruncate, MulTruncate?
I think it should be fixed separately after decided on #380

and I'd appreciate it if you could resolve the conflict.

@hallazzang hallazzang removed the request for review from defihyung June 2, 2021 16:51
@hallazzang
Copy link
Contributor Author

@dongsam It has changed, please check it again.

@dongsam dongsam merged commit 5f19607 into tendermint:develop Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle problems of sending coins to the reserve account
2 participants