Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for new login method #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cq674350529
Copy link
Contributor

Login method has been changed since 6.43. So add support for it in winbox communication and keep the remaining unchanged.

Also, we can use the new login method direcly, like execute_milo does.

@jacob-baines
Copy link
Contributor

Thanks @cq674350529! I'm traveling a bit so this will sit around for a few days before I get a good look at it. But yeah, good PR. I was super lazy about only putting the login in milo 😬

@cq674350529
Copy link
Contributor Author

Take your time! Learnt a lot from both your slides and codes 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants