Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Set buildvcs flag to false in docker build. #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

psigen
Copy link

@psigen psigen commented Oct 20, 2022

What changed?

I added a -buildvcs=false flag to the go build step inside the dockerfile.

Why?

This is a workaround to #156
I'm not sure if this is the best way to do this, but it does work.

How did you test it?

I ran docker build . before and after the change.

Potential risks

This may strip VCS information that someone is using, I am not sure if it is necessary to use this flag in the docker image.

Is hotfix candidate?

No

@sagikazarmark
Copy link

I'm not entirely sure temporalite is supposed to be used as a submodule. IMO it's an edge case enough to not disable the buildvcs flag by default.

If all else fails, I'd recommend adding a build arg so that you can manually disable it during a docker build.

@wit-0-bit
Copy link

wit-0-bit commented Mar 7, 2023

I'm not entirely sure temporalite is supposed to be used as a submodule.

Maybe I am missing something here, but why should it matter if it's in a submodule? For context, I've a docker based development setup which needs to be distributed across a small team. Adding this project as a submodule and referencing the Dockerfile here in the docker compose file seemed like it would have been a pretty reasonable thing to do but I was blocked by this issue. I ended up making another Dockerfile and grabbing a binary from the release page.

To be clear, I am not saying this flag should be disabled. Admittedly I am not sure exactly what the flag does or how it benefits a docker build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants