Setup with gotbook and remove unneded files #303
Conversation
Pull Request Test Coverage Report for Build 394496586
💛 - Coveralls |
e286d25
to
b08672b
Compare
Thanks, can you create a gitbook space from your local branch so we can preview this and future changes before merging. Maybe create a gitbook space linked to your main repo and can just merge this and future PRs there so we can preview latest changes Can you also add in this PR the .gitbook config file to adjust that the root folder is |
35a629f
to
74499b3
Compare
I made required changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, we are getting there.
Can you also add the changelog as this is also usefull to keep in the logs.
In a follow up PR would be interested to see how can we avoid maintaining a SUMMARY.md file , I guess naming the files properly with some numbers in front would be enough to organize the pages nicely.
Co-authored-by: Krasimir Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
Ok, naming seems to be a good idea to me too. Also, to achieve this we need to update GitHub action in TellorDocs repo too. |
yes lets do that and just set the root folder through the .gitbook config file I want to avoid maintaining the summary file because it will be error prone. so easy to forget when you add/remove/rename files. |
Ok, I just did that. I believe we need a summary and readme in .gitbook.yaml if we want Telliot docs to be compatible with Gitbook, otherwise we need to have our warning in docs/README.md too. |
What do you mean by |
b161416
to
4575e93
Compare
done |
Oooh I just realised that you can even delete the README.md in the root folder as github will show the one from see here:
|
Co-authored-by: Krasimir Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
Yep looking good, really glad how simple it is now. Thanks for doing this! Now lets see how the sync will work. |
You're welcome! Thanks for your help!
|
yep, I would like to do a bit of refactoring of the text as well, but let's fix and test the auto-sync first. Btw I have sent you a request to chat on google hangout, it might be easier and quicker to sync for the last PR. Or if you use any other chat client let me know where to find you. |
Ok, sure. can you please ping me on Discord or Telegram? |
Description
Add warning to README.md
Add intro to Gitbook doc
Refs
#268
TellorDocs#7