Skip to content
This repository has been archived by the owner on Sep 21, 2022. It is now read-only.

Setup with gotbook and remove unneded files #303

Merged
merged 15 commits into from Dec 1, 2020

Conversation

hhio618
Copy link
Contributor

@hhio618 hhio618 commented Nov 30, 2020

Description

Add warning to README.md
Add intro to Gitbook doc

Refs

#268
TellorDocs#7

@coveralls
Copy link

coveralls commented Nov 30, 2020

Pull Request Test Coverage Report for Build 394496586

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 36.318%

Totals Coverage Status
Change from base Build 392040541: 0.05%
Covered Lines: 1525
Relevant Lines: 4199

💛 - Coveralls

@krasi-georgiev
Copy link
Collaborator

Thanks, can you create a gitbook space from your local branch so we can preview this and future changes before merging.

Maybe create a gitbook space linked to your main repo and can just merge this and future PRs there so we can preview latest changes

Can you also add in this PR the .gitbook config file to adjust that the root folder is ./docs

@hhio618
Copy link
Contributor Author

hhio618 commented Nov 30, 2020

I made required changes.
Please see Gitbook space here

Copy link
Collaborator

@krasi-georgiev krasi-georgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we are getting there.

Can you also add the changelog as this is also usefull to keep in the logs.

In a follow up PR would be interested to see how can we avoid maintaining a SUMMARY.md file , I guess naming the files properly with some numbers in front would be enough to organize the pages nicely.

docs/contributing.md Outdated Show resolved Hide resolved
hhio618 and others added 2 commits December 1, 2020 10:51
Co-authored-by: Krasimir Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
@hhio618
Copy link
Contributor Author

hhio618 commented Dec 1, 2020

In a follow up PR would be interested to see how can we avoid maintaining a SUMMARY.md file , I guess naming the files properly with some numbers in front would be enough to organize the pages nicely.

Ok, naming seems to be a good idea to me too. Also, to achieve this we need to update GitHub action in TellorDocs repo too.
I think we can remove SUMMARY.md in this PR then.

@krasi-georgiev
Copy link
Collaborator

krasi-georgiev commented Dec 1, 2020

Ok, naming seems to be a good idea to me too. Also, to achieve this we need to update GitHub action in TellorDocs repo too.
I think we can remove SUMMARY.md in this PR then.

yes lets do that and just set the root folder through the .gitbook config file

I want to avoid maintaining the summary file because it will be error prone. so easy to forget when you add/remove/rename files.
For now lets just set the root folder through the .gitbook file and in a follow up PR will arrange the files. We need to merge few of those and do a bit of refactoring in general.

@hhio618
Copy link
Contributor Author

hhio618 commented Dec 1, 2020

For now lets just set the root folder through the .gitbook file and in a follow up PR will arrange the files. We need to merge few of those and do a bit of refactoring in general.

Ok, I just did that. I believe we need a summary and readme in .gitbook.yaml if we want Telliot docs to be compatible with Gitbook, otherwise we need to have our warning in docs/README.md too.

README.md Outdated Show resolved Hide resolved
@krasi-georgiev
Copy link
Collaborator

krasi-georgiev commented Dec 1, 2020

Ok, I just did that. I believe we need a summary and readme in .gitbook.yaml if we want Telliot docs to be compatible with Gitbook, otherwise we need to have our warning in docs/README.md too.

What do you mean by compatible with gitbook? But yes please move the warning in docs/REA...

@hhio618
Copy link
Contributor Author

hhio618 commented Dec 1, 2020

What do you mean by compatible with gitbook? But yes please move the warning in docs/REA...

done
I actually checked this, there is nothing to worry.

@krasi-georgiev
Copy link
Collaborator

Oooh I just realised that you can even delete the README.md in the root folder as github will show the one from docs/README.md

see here:

If you put your README file in your repository's root, docs, or hidden .github directory, GitHub will recognize and automatically surface your README to repository visitors.

https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-readmes#about-readmes

.gitbook.yaml Outdated Show resolved Hide resolved
Co-authored-by: Krasimir Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
@krasi-georgiev
Copy link
Collaborator

Yep looking good, really glad how simple it is now. Thanks for doing this!

Now lets see how the sync will work.

@krasi-georgiev krasi-georgiev changed the title Add introduction to gitbook Setup with gotbook and remove unneded files Dec 1, 2020
@krasi-georgiev krasi-georgiev merged commit d115c7c into tellor-io:master Dec 1, 2020
@hhio618
Copy link
Contributor Author

hhio618 commented Dec 1, 2020

You're welcome! Thanks for your help!
I think we need two other PRs.

  1. first for arranging files inside docs folder
  2. second updating GitHub action to add these arranged files to table of contents

@krasi-georgiev
Copy link
Collaborator

krasi-georgiev commented Dec 1, 2020

yep, I would like to do a bit of refactoring of the text as well, but let's fix and test the auto-sync first. Btw I have sent you a request to chat on google hangout, it might be easier and quicker to sync for the last PR. Or if you use any other chat client let me know where to find you.

@hhio618
Copy link
Contributor Author

hhio618 commented Dec 1, 2020

Ok, sure. can you please ping me on Discord or Telegram?
handle: @hhio618

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants