change errors.Errorf to *.Wrapf and *.Wrap #286
Conversation
a3a391d
to
265449a
Compare
265449a
to
8ef2340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, left few comments, please have a look at all other occurrences and continue in the same direction.
@krasi-georgiev thanks for review! I make changes. |
please change the rest of the PR according to my comments as these changes apply in many different places not just the ones I pointed. To save time please review our errors format guidlines |
ccd386f
to
d7c62ce
Compare
ping when ready for another review or if you get stuck making all tests pass. |
a917c81
to
61156bc
Compare
Pull Request Test Coverage Report for Build 374531539
💛 - Coveralls |
@krasi-georgiev double check in files and test pass done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going in a good direction, thanks.
Please review my comments and check the rest of the pr to make sure you apply the same principles everywhere.
46f558d
to
20fcff3
Compare
20fcff3
to
2913e8d
Compare
f478ae4
to
dbb5b0b
Compare
dbb5b0b
to
814b706
Compare
for the CI error you can run |
814b706
to
7d4b3d6
Compare
btw in few minutes will merge another big PR that does some other global refactorings so there will be some conflict to be resolved and unfortunately we can't avoid it, but shouldn't be too difficult to resolve. |
ab293f1
to
73f63cd
Compare
* add errors.Wrap() on `pkg/pow/pool.go` * add errors.Wrap() on `pkg/db/remoteRequest.go`
73f63cd
to
bf0a81d
Compare
4a0cca3
to
9e6d6c0
Compare
Pull Request Test Coverage Report for Build 375517800
💛 - Coveralls |
9e6d6c0
to
f01d17f
Compare
f01d17f
to
b7d01b7
Compare
Thanks! |
fixes: #236
Fix
#236 (comment)