Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync telliot docs using Github actions #5

Merged
merged 6 commits into from Nov 29, 2020

Conversation

hhio618
Copy link
Contributor

@hhio618 hhio618 commented Nov 28, 2020

@@ -0,0 +1,47 @@
# Sync miner docs from https://github.com/tellor-io/telliot/tree/master/docs in miner-documentation folder in the current repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename the Miner folder to Telliot and will refactor the docs to explain that one of the tasks that Telliot does is mining.

if [ "$TELLIOT_MD5" != "$CURRENT_MD5" ];
then
sed -i 's/(/(miner-documentation\//g' ./telliot/docs/INDEX.md
python .github/workflow/update-summary.py ./telliot/docs/INDEX.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put an INDEX.md file in Telliot docs folder which contains Telliot table of content. This way the main docs can be in sync with Telliot table of content and we don't need to manually edit the SUMMARY.md file every time the auto-sync process creates a PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah yeah I see what you mean. Lets call it SUMMARY.md to be consistent and also when opening the Telliot dedicated gitbook space it will be used as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in the Telliot repo we would need to add a .gitbook.yaml to specify the root folder and the location of the summary there.

https://docs.gitbook.com/integrations/github/content-configuration#summary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I changed the action to handle a SUMMARY.md file.

@krasi-georgiev
Copy link
Contributor

I don't have merge access to this repo but asked for access and will merge soon

@krasi-georgiev krasi-georgiev merged commit a0e6532 into tellor-io:master Nov 29, 2020
@krasi-georgiev
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants