This repository has been archived by the owner on Oct 9, 2019. It is now read-only.
WIP: fix heroku deployment #339
Open
lexoyo
wants to merge
4
commits into
tellform:master
Choose a base branch
from
lexoyo:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recent heroku deployments do not need Procfile anymore, they use `npm start` plus this Procfile is bugguy
Thanks for the PR have you tried pinging people on the Gitter for assistance? |
Oh no, I'll do that thx |
it may be futile it seems like the majority of people in there are wanting
the product but are all struggling to get it working.
…On Fri, Jun 7, 2019 at 10:56 PM Alex Hoyau ***@***.***> wrote:
Oh no, I'll do that thx
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#339?email_source=notifications&email_token=AAIE2VWIMXVJIO4QPB2FHADPZMNW5A5CNFSM4HWAR5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHLXEQ#issuecomment-500087698>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VQVABBHBVI5Q7XMDYDPZMNW5ANCNFSM4HWAR5LQ>
.
|
It is always hard to maintain a product which targets non-developers because the users can not contribute. Also the code of tellform is already old and not so robust, so it would require some deep refactoring, which might not even be accepted by the maintainers I believe it is futile sadly... I wanted to integrate it with silex.me, an open source project I maintain. I maintain it also because I sell website designers create with it, so I can spend a lot of time working on it. Even like this it is difficult to maintain I'll think about it if I have time to push this PR forward. Have a nice day ! |
Its definitely a concern the code is definitely aging there are a number of
concerns that I have that would put me into a position to not recommend the
usage of this project in it's the current state. You're right about
needing a refactor but it also has a few vulnerabilities that are in the
upstream packages.
…On Sat, Jun 8, 2019 at 1:01 PM Alex Hoyau ***@***.***> wrote:
It is always hard to maintain a product which targets non-developers
because the users can not contribute.
Also the code of tellform is already old and not so robust, so it would
require some deep refactoring, which might not even be accepted by the
maintainers
I believe it is futile sadly... I wanted to integrate it with silex.me,
an open source project I maintain. I maintain it also because I sell
website designers create with it, so I can spend a lot of time working on
it. Even like this it is difficult to maintain
I'll think about it if I have time to push this PR forward. Have a nice
day !
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#339?email_source=notifications&email_token=AAIE2VWLE2QBPOBSWJ4QQD3PZPQYJA5CNFSM4HWAR5L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHYXHY#issuecomment-500140959>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIE2VXBSZR2ZGC3FG4VV3TPZPQYJANCNFSM4HWAR5LQ>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent heroku deployments do not need Procfile anymore, they use
npm start
plus this Procfile is bugguy
But the
npm start
of tellform right now uses grunt whith some grunt plugins declared as dev-dependencies and a linter which fails, so I needed to touch these too.Note that this is not only heroku but any server which needs to do npm start in a production environment without forever or watch
Motivation and Context
fix #324
How Has This Been Tested?
deploy on heroku almost worked, there is still an issue, maybe someone can help me with the grunt config since I did not use grunt in a long time:
NODE_ENV=development node_modules/.bin/grunt build
worksNODE_ENV=production node_modules/.bin/grunt build
produces all the files, no error, no js error at runtime (client and server) but the page is blank. everything seems to load:Types of changes
Checklist: