Skip to content
This repository has been archived by the owner on Oct 9, 2019. It is now read-only.

WIP: fix heroku deployment #339

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: fix heroku deployment #339

wants to merge 4 commits into from

Conversation

lexoyo
Copy link

@lexoyo lexoyo commented Jun 8, 2019

Description

Recent heroku deployments do not need Procfile anymore, they use npm start
plus this Procfile is bugguy

But the npm start of tellform right now uses grunt whith some grunt plugins declared as dev-dependencies and a linter which fails, so I needed to touch these too.

Note that this is not only heroku but any server which needs to do npm start in a production environment without forever or watch

Motivation and Context

fix #324

How Has This Been Tested?

deploy on heroku almost worked, there is still an issue, maybe someone can help me with the grunt config since I did not use grunt in a long time:

  • NODE_ENV=development node_modules/.bin/grunt build works
  • NODE_ENV=production node_modules/.bin/grunt build produces all the files, no error, no js error at runtime (client and server) but the page is blank. everything seems to load:

Screenshot from 2019-06-07 20-22-07

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Leopere
Copy link
Collaborator

Leopere commented Jun 8, 2019

Thanks for the PR have you tried pinging people on the Gitter for assistance?

@lexoyo
Copy link
Author

lexoyo commented Jun 8, 2019

Oh no, I'll do that thx

@Leopere
Copy link
Collaborator

Leopere commented Jun 8, 2019 via email

@lexoyo
Copy link
Author

lexoyo commented Jun 8, 2019

It is always hard to maintain a product which targets non-developers because the users can not contribute.

Also the code of tellform is already old and not so robust, so it would require some deep refactoring, which might not even be accepted by the maintainers

I believe it is futile sadly... I wanted to integrate it with silex.me, an open source project I maintain. I maintain it also because I sell website designers create with it, so I can spend a lot of time working on it. Even like this it is difficult to maintain

I'll think about it if I have time to push this PR forward. Have a nice day !

@Leopere
Copy link
Collaborator

Leopere commented Jun 8, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants