New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Triggers v0.27.x release #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind misc
I'm not sure why it's failing tests. I changed displayName to use .x earlier. |
/retest |
/assign @AlanGreene |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khrm
I don't see v0.26 in https://github.com/tektoncd/triggers/blob/main/releases.md but assume it was a regular release (i.e. not LTS).
EDIT: I see you have tektoncd/triggers#1729 to document v0.26 as an LTS release.
This means v0.23 and v0.25 are EOL and should be removed from the list so that we only provide documentation on the website for currently supported releases.
Based on the comments in the PR above I assume v0.27 is also LTS. Can you update the display names for both to mark them as LTS for users? (i.e. v0.27.x-LTS and v0.26.x-LTS)?
It would also be really helpful to include 'LTS' in the GitHub release names to make this obvious.
Thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@AlanGreene 26 was LTS. Doc PR isn't merged. Let me check what are the supported releases. |
/lgtm |
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.