Adds PostgreSQL Database Table Schema to Configuration #677

chriscannon · 2023-12-04T21:42:07Z

Changes

This allows a schema to be set on the table instead of assuming public.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Tested your changes locally (if this is a code change)
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

PostgreSQL table schema can be set using the DB_SCHEMA environment and configuration variable.

linux-foundation-easycla · 2023-12-04T21:42:14Z

The committers listed above are authorized under a signed CLA.

✅ login: chriscannon / name: Chris Cannon (9d90c6c, 5f0c214)

tekton-robot · 2023-12-04T21:42:17Z

Hi @chriscannon. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chriscannon · 2023-12-04T21:46:08Z

/kind feature

sayan-biswas · 2023-12-06T05:59:36Z

/ok-to-test

tekton-robot · 2024-01-03T19:15:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-results-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/api/main.go	11.9%	11.7%	-0.2

adambkaplan

/approve

Looks good to me!

tekton-robot · 2024-01-05T21:42:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chriscannon · 2024-01-11T20:08:25Z

@adambkaplan could you also add a lgtm label so that it can pass the CI validation? Thanks!

adambkaplan

I gave this a bit closer scrutiny before providing lgtm.

@chriscannon are you able to squash your commits and provide a descriptive commit message once the items below are addressed?

@tektoncd/operator-maintainers fyi I think this feature would impact any operator-managed deployment of Tekton Results

adambkaplan · 2024-01-11T20:34:51Z

cmd/api/main.go

@@ -100,7 +98,9 @@ func main() {
 	var err error

 	dbURI := fmt.Sprintf("host=%s user=%s password=%s dbname=%s port=%s sslmode=%s sslrootcert=%s", serverConfig.DB_HOST, serverConfig.DB_USER, serverConfig.DB_PASSWORD, serverConfig.DB_NAME, serverConfig.DB_PORT, serverConfig.DB_SSLMODE, serverConfig.DB_SSLROOTCERT)
-	gormConfig := &gorm.Config{}
+	gormConfig := &gorm.Config{NamingStrategy: schema.NamingStrategy{


It is not readily clear from the code that this is how you set the Postgresql "schema" using gorm. Can you please add a comment with a link to the relevant docs in gorm?

adambkaplan · 2024-01-11T20:36:33Z

config/base/env/config

@@ -3,6 +3,7 @@ DB_PASSWORD=
 DB_HOST=
 DB_PORT=5432
 DB_NAME=
+DB_SCHEMA=public


This becomes the default "table prefix" value in our distribution. Will this break the database initialization/auto-migration phase of the deployment on upgrade? Is there risk of data being "orphaned" because the apiserver will create a whole new schema in Postgres?

tekton-robot · 2024-01-29T16:04:06Z

@chriscannon: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adds db schema to configuration

9d90c6c

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 4, 2023

tekton-robot requested review from alan-ghelardi and dibyom December 4, 2023 21:42

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 4, 2023

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2023

only set the table prefix if a db schema is set

5f0c214

adambkaplan approved these changes Jan 5, 2024

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 11, 2024

adambkaplan reviewed Jan 11, 2024

View reviewed changes

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds PostgreSQL Database Table Schema to Configuration #677

Adds PostgreSQL Database Table Schema to Configuration #677

chriscannon commented Dec 4, 2023 •

edited by adambkaplan

linux-foundation-easycla bot commented Dec 4, 2023 •

edited

tekton-robot commented Dec 4, 2023

chriscannon commented Dec 4, 2023

sayan-biswas commented Dec 6, 2023

tekton-robot commented Jan 3, 2024

adambkaplan left a comment

tekton-robot commented Jan 5, 2024

chriscannon commented Jan 11, 2024

adambkaplan left a comment

adambkaplan Jan 11, 2024

adambkaplan Jan 11, 2024

tekton-robot commented Jan 29, 2024

Adds PostgreSQL Database Table Schema to Configuration #677

Are you sure you want to change the base?

Adds PostgreSQL Database Table Schema to Configuration #677

Conversation

chriscannon commented Dec 4, 2023 • edited by adambkaplan

Changes

Submitter Checklist

Release Notes

linux-foundation-easycla bot commented Dec 4, 2023 • edited

tekton-robot commented Dec 4, 2023

chriscannon commented Dec 4, 2023

sayan-biswas commented Dec 6, 2023

tekton-robot commented Jan 3, 2024

adambkaplan left a comment

Choose a reason for hiding this comment

tekton-robot commented Jan 5, 2024

chriscannon commented Jan 11, 2024

adambkaplan left a comment

Choose a reason for hiding this comment

adambkaplan Jan 11, 2024

Choose a reason for hiding this comment

adambkaplan Jan 11, 2024

Choose a reason for hiding this comment

tekton-robot commented Jan 29, 2024

chriscannon commented Dec 4, 2023 •

edited by adambkaplan

linux-foundation-easycla bot commented Dec 4, 2023 •

edited