Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tektoncd/Pipeline integration tests from prow to tekton #1292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Migrate tektoncd/Pipeline integration tests from prow to tekton #1292

wants to merge 1 commit into from
+152 −2

Conversation

chitrangpatel
Copy link
Member

@chitrangpatel chitrangpatel commented Nov 26, 2022 •
edited

This PR allows us to run the tektonCD/pipeline's integration tests on the tekton dogfooding cluster using a pipeline instead of a prow job.

Changes

  • Added the trigger template for integration and alpha-integration tests in tekton/ci/repos/pipeline/template.yaml (to spawn the pipeline run).

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 26, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2022
@chitrangpatel
Copy link
Member Author

chitrangpatel commented Nov 26, 2022 via email

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2022
@chitrangpatel
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2022
@chitrangpatel chitrangpatel force-pushed the migrate_integration_tests_to_tekton branch from 9ac20e9 to f3d39e3 Compare December 8, 2022 14:48
@chitrangpatel chitrangpatel force-pushed the migrate_integration_tests_to_tekton branch 2 times, most recently from 9497452 to 52b6501 Compare January 19, 2023 14:44
@QuanZhang-William QuanZhang-William mentioned this pull request Feb 14, 2023
Closed
2 tasks
@lbernick
Copy link
Member

lbernick commented Apr 3, 2023

Partially addresses #1264

@chitrangpatel chitrangpatel mentioned this pull request Apr 3, 2023
Closed
lbernick
lbernick reviewed Apr 3, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold until #1388 is resolved

tekton/ci/repos/pipeline/template.yaml Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@chitrangpatel chitrangpatel force-pushed the migrate_integration_tests_to_tekton branch from 52b6501 to 2990e40 Compare June 19, 2023 19:46
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@tekton-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@chitrangpatel
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2023
@chitrangpatel
Copy link
Member Author

/retest

@chitrangpatel
Copy link
Member Author

/test plumbing-unit-tests

@tekton-robot
Copy link
Contributor

@chitrangpatel: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-dogfooding-mario-test
  • /test pull-tekton-plumbing-check-testgrid-config

In response to this:

/test plumbing-unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lbernick
lbernick reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will these tests be blocking as soon as this PR is merged?

tekton/ci/repos/pipeline/template.yaml Outdated Show resolved Hide resolved
@chitrangpatel
Copy link
Member Author

will these tests be blocking as soon as this PR is merged?

I think once this PR is merged, within an hour or so I think (whenever our CI system updates), we will start running it like we do the go-coverage-df tests.

Let me hold it and we can unhold it after the production WG call this week. My fear is what would happen if we roll this out and it fails. Would it stop all PRs from being merged?

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2023
@chitrangpatel
Migrating tekton pipeline integration from prow to tekton
388501f 
This PR allows us to run the tektonCD/pipeline's integration tests on the tekton dogfooding cluster using a pipeline instead of a prow job.
@chitrangpatel chitrangpatel force-pushed the migrate_integration_tests_to_tekton branch from 2990e40 to 388501f Compare June 20, 2023 14:19
@tekton-robot
Copy link
Contributor

The following Tekton test failed:

Test name Commit Details Required Rerun command
plumbing-unit-tests 388501f link true /test plumbing-unit-tests

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 18, 2023
@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@lbernick lbernick lbernick left review comments

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

@wlynch wlynch Awaiting requested review from wlynch

Assignees

@lbernick lbernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chitrangpatel @tekton-robot @lbernick @vdemeester @afrittoli