Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pages for StepActions #3360

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Mar 22, 2024

Changes

Resolves #3348

Add list and details pages for the v1alpha1 StepActions resources following the same pattern as the existing Tasks / Pipelines page. The only difference is that we don't link to associated runs or provide the ability to create a run as a StepAction must be used in a Task and cannot be run standalone.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 22, 2024
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 22, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from alangreene after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlanGreene AlanGreene requested review from briangleeson and removed request for skaegi March 22, 2024 18:21
@AlanGreene
Copy link
Member Author

/test all

@AlanGreene
Copy link
Member Author

StepActions was added in Pipelines v0.54.0 and is currently alpha. It is expected to be promoted to beta around the v0.60.0 / June timeframe.

The latest Dashboard release (v0.45.0) still supports Pipelines v0.53.0, so we might wait until we drop support for that before landing this change.

Add list and details pages for the v1alpha1 StepActions resources
following the same pattern as the existing Tasks / Pipelines page.
The only difference is that we don't link to associated runs or
provide the ability to create a run as a StepAction must be used
in a Task and cannot be run standalone.
@AlanGreene
Copy link
Member Author

/test all

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2024
@tekton-robot
Copy link
Contributor

@AlanGreene: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add StepActions to the Dashboard
2 participants