Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vcs links to be static #2304

Closed
wants to merge 1 commit into from
Closed

Fix vcs links to be static #2304

wants to merge 1 commit into from

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented May 2, 2024 •
edited

this will fix the pre-commit run

Fixes #2303

NONE

Signed-off-by: Chmouel Boudjnah chmouel@redhat.com

@chmouel
Fix vcs links to be static
13f9a39 
this will fix the pre-commit run

Fixes tektoncd#2303

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from chmouel after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 2, 2024
@chmouel
Copy link
Member Author

chmouel commented May 2, 2024

/test pull-tekton-cli-build-tests

1 similar comment
@chmouel
Copy link
Member Author

chmouel commented May 2, 2024

/test pull-tekton-cli-build-tests

@tekton-robot
Copy link
Contributor

@chmouel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-cli-build-tests 13f9a39 link true /test pull-tekton-cli-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@piyush-garg
Copy link
Contributor

Error is

----------------------------------------------
RELEASE_PROCESS.md
	ERROR	https://archlinux.org/packages/community/x86_64/tekton-cli/flag/
		Not Found (HTTP error 404)
	ERROR	https://github.com/Homebrew/homebrew-core/blob/master/Formula/tektoncd-cli.rb
		Not Found (HTTP error 404)

piyush-garg
piyush-garg reviewed May 6, 2024
View reviewed changes
RELEASE_PROCESS.md
@@ -55,7 +55,7 @@ dnf upgrade tektoncd-cli

- Make an update on [homebrew-core](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tektoncd-cli.rb) for tektoncd-cli formula.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this also needs update

piyush-garg
piyush-garg reviewed May 6, 2024
View reviewed changes
RELEASE_PROCESS.md


- Go to https://archlinux.org/packages/community/x86_64/tekton-cli/flag/ and let the packagers know the package is out of date by leaving a message to the release url and your email address so they can update it.
- Go to <https://archlinux.org/packages/community/x86_64/tekton-cli/flag/> and let the packagers know the package is out of date by leaving a message to the release url and your email address so they can update it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be https://archlinux.org/packages/extra/x86_64/tekton-cli/flag/

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024
@tekton-robot
Copy link
Contributor

@chmouel: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chmouel chmouel closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-commit on cli repo is broken
3 participants
@chmouel @tekton-robot @piyush-garg