PipelineRuns with v2alpha4 to process StepActions #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/XXL
|
Hi @renzodavid9. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
needs-ok-to-test
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
from
12d8357
to
265c09d
Compare
renzodavid9
changed the title
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
4 times, most recently
from
0cbce63
to
9250178
Compare
tekton-robot
added
ok-to-test
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
from
9250178
to
9a04b10
Compare
tekton-robot
added
the
needs-rebase
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
from
9a04b10
to
08fd75f
Compare
tekton-robot
removed
the
needs-rebase
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
3 times, most recently
from
5d27a66
to
2586135
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
The following is the coverage report on the affected files.
|
|
Please fix the linter errors and add a release note. |
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
from
2586135
to
6872bd3
Compare
|
The following is the coverage report on the affected files.
|
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
2 times, most recently
from
3522d9d
to
c79c0e1
Compare
|
The following is the coverage report on the affected files.
|
This new version will now process the information from any associated StepAction from the executed PipelineRun when `artifacts.pipelinerun.enable-deep-inspection` is set to `true`. Also, the way chains read results from PipelineRuns to populate the `subjects` field is changing: now the user has to explicitly mark a result as a subject using an object type-hinted tag (*ARTIFACT_OUTPUTS) + the new `isBuildArtifact` property in the value. Refactors to share logic between v2alph3 and v2alpha4.
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
from
c79c0e1
to
e72c6e7
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
Thanks for the cleanup Renzo! Happy to approve after fixing the linter error. |
…hen two or more tasks/steps are using the same prefix.
renzodavid9
force-pushed
the
1065-stepactions-with-pipelines
branch
from
7a1ee59
to
323779b
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
chitrangpatel
approved these changes
May 22, 2024
There was a problem hiding this comment.
Thanks for you work on this Renzo! It wraps up support for StepResults as discussed in issue
#1065
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version will now process the information from any associated StepAction from the executed PipelineRun.
Also, the way chains read results from PipelineRuns to populate the
subjectsfield is changing: now the user has to explicitly mark a result as a subject using an bject type-hinted tag (*ARTIFACT_OUTPUTS) + the newisBuildArtifactproperty in the value.Refactors to share logic between v2alph3 and v2alpha4.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes