Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix m_pa* variable naming to m_ap* #3243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChillerDragon
Copy link
Contributor

@ChillerDragon ChillerDragon commented Mar 23, 2024

Fixed using the following shell script

#!/bin/sh

grep -rEo '\bm_paa[A-Z][a-zA-Z0-9]+' src | cut -d':' -f2- | sort -u |
while read -r var
        do
                new="m_aap$(printf '%s' "$var" | cut -c 6-)"
                perl -i -p -e's/\b'"$var"'\b/'"$new"'/g' $(find . -name
'*.h' -o -name '*.cpp' -o -name '*.c')
        done

grep -rEo '\bm_pa[A-Z][a-zA-Z0-9]+' src | cut -d':' -f2- | sort -u |
while read -r var
        do
                new="m_ap$(printf '%s' "$var" | cut -c 5-)"
                perl -i -p -e's/\b'"$var"'\b/'"$new"'/g' $(find . -name
'*.h' -o -name '*.cpp' -o -name '*.c')
        done

Fixed using the following shell script

```
#!/bin/sh

grep -rEo '\bm_paa[A-Z][a-zA-Z0-9]+' src | cut -d':' -f2- | sort -u |
while read -r var
        do
                new="m_aap$(printf '%s' "$var" | cut -c 6-)"
                perl -i -p -e's/\b'"$var"'\b/'"$new"'/g' $(find . -name
'*.h' -o -name '*.cpp' -o -name '*.c')
        done

grep -rEo '\bm_pa[A-Z][a-zA-Z0-9]+' src | cut -d':' -f2- | sort -u |
while read -r var
        do
                new="m_ap$(printf '%s' "$var" | cut -c 5-)"
                perl -i -p -e's/\b'"$var"'\b/'"$new"'/g' $(find . -name
'*.h' -o -name '*.cpp' -o -name '*.c')
        done
```
@@ -162,7 +162,7 @@ class CTextRender : public IEngineTextRender
// support regional variant fonts
int m_NumVariants;
int m_CurrentVariant;
CFontLanguageVariant *m_paVariants;
CFontLanguageVariant *m_apVariants;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m_paVariants or m_pVariants seems to be correct here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants