Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make_release.py options #3226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChillerDragon
Copy link
Contributor

The help page advertises options such as -m and -s but none of these can be used because the script refuses to launch if more than 2 arguments are passed

$ python scripts/make_release.py -h
Usage: make_release.py VERSION PLATFORM [options]

VERSION  - Version number
PLATFORM - Target platform (f.e. linux_x86, linux_x86_64, macos, src, win32, win64)

Options:
  -h, --help            show this help message and exit
  -l URL_LANGUAGES, --url-languages=URL_LANGUAGES
                        URL from which the teeworlds language files will be
                        downloaded
  -m URL_MAPS, --url-maps=URL_MAPS
                        URL from which the teeworlds maps files will be
                        downloaded
  -s SOURCE_DIR, --source-dir=SOURCE_DIR
                        Source directory which is used for building the
                        package
$ python scripts/make_release.py master macos --url-maps=https://github.com/teeworlds/teeworlds-translation/archive/master.zip
wrong number of arguments
scripts/make_release.py VERSION PLATFORM

The help page advertises options such as -m and -s
but none of these can be used because the script refuses to launch
if more than 2 arguments are passed

$ python scripts/make_release.py -h
Usage: make_release.py VERSION PLATFORM [options]

VERSION  - Version number
PLATFORM - Target platform (f.e. linux_x86, linux_x86_64, macos, src, win32, win64)

Options:
  -h, --help            show this help message and exit
  -l URL_LANGUAGES, --url-languages=URL_LANGUAGES
                        URL from which the teeworlds language files will be
                        downloaded
  -m URL_MAPS, --url-maps=URL_MAPS
                        URL from which the teeworlds maps files will be
                        downloaded
  -s SOURCE_DIR, --source-dir=SOURCE_DIR
                        Source directory which is used for building the
                        package
$ python scripts/make_release.py master macos --url-maps=https://github.com/teeworlds/teeworlds-translation/archive/master.zip
wrong number of arguments
scripts/make_release.py VERSION PLATFORM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant