Remove unreachable dmg indicator code

[ChillerDragon]

teeworlds/datasrc/network.py

Line 253 in a1911c8

NetIntRange("m_ClientID", 0, 'MAX_CLIENTS-1'),

NetEvent("Damage:Common", [ # Unused yet
	NetIntRange("m_ClientID", 0, 'MAX_CLIENTS-1'),
	NetIntAny("m_Angle"),
	NetIntRange("m_HealthAmount", 0, 9),
	NetIntRange("m_ArmorAmount", 0, 9),
	NetBool("m_Self"),
]),

Snap items with a m_ClientID out of range will be dropped during snap item validation.

Thanks to @TsFreddie the original author of this code for helping me figure this out c:

[ChillerDragon]

Now that I think about it thats not very nice. The way I understand it the m_Angle parameter is fully ignored at all times. The server sends it as part of the damage snap event. But then the client overwrites it at all times with its locally computed value. This dead branch was the only place were the client would use the angle sent by the server. But it is unreachable due to the validation that invalidates the snap item with the client id out of bounds. So I would propose to remove the validation or maybe loosen it up to allow something like NetIntRange("m_ClientID", -1, 'MAX_CLIENTS-1'), where -1 is supposed to be used for the custom angles and the rest is for client ids.

The 0.7 protocol includes this parameter and there should be a way to use it. Imo it can be done before 0.8 and older clients simply see no damage indicators if a server decides to send client id -1 with a custom angle.