Fix compatibility with Node.js 12.4 and newer #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL Server expects individual TLS segments to never contain more data than the negotiated TDS packet size. If this is not the case, SQL Server will simply drop the connection without warning. Since Node.js 12.4, `TLSSocket`s try to fit as much data as possible into a TLS fragment. Because the default TLS fragment size is `16384` bytes, and this does not necessarily match the negotiated TDS packet size, users of Node.js 12.4 and newer would encounter sudden connection drops (e.g. when sending large queries). By keeping the TLS fragment size and the negoitated TDS packet size in sync, we can make sure SQL Server does not drop the connection.
arthurschreiber
force-pushed
the
arthur/fix-node-12-compat
branch
from
66eead6
to
860e706
Compare
|
🎉 This PR is included in version 6.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL Server expects individual TLS segments to never contain more data than the negotiated TDS packet size. If this is not the case, SQL Server will simply drop the connection without warning.
Since Node.js 12.4,
TLSSockets try to fit as much data as possible into a TLS fragment. Because the default TLS fragment size is16384bytes, and this does not necessarily match the negotiated TDS packet size, users of Node.js 12.4 and newer would encounter sudden connection drops (e.g. when sending large queries).By keeping the TLS fragment size and the negoitated TDS packet size in sync, we can make sure SQL Server does not drop the connection.
Fixes: #923