New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bibtex cleanups / type improvements #1163
base: master
Are you sure you want to change the base?
Bibtex cleanups / type improvements #1163
Conversation
5715551
to
85a1e2b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
- Coverage 46.41% 46.37% -0.04%
==========================================
Files 176 174 -2
Lines 65121 65180 +59
==========================================
+ Hits 30223 30228 +5
- Misses 34898 34952 +54 ☔ View full report in Codecov by Sentry. |
Created a new branch off this to play around with an idea I've had that will probably not be part of this PR (which I'm hoping to get merged after I fix up the test I broke) - take a look at CraftSpider@75f5c96 on my bibtex-parsing branch for a new way to parse things. It manages to separate out aux parsing into two parts, just parsing the line, then emitting warnings and making state changes. The parsing part is entirely separate from state, and as such, can now be unit-tested quite easily. DisclaimerThe library I used, |
…e from the running context itself
…a more type-strict
bec9bbf
to
88f0e86
Compare
Best reviewed commit-by-commit if you're looking to understand every change.
This work, so far:
Vec
instead of a custom buffer type everywherelookup_str
is defined - it's primarily about the hash, only tangentially touching the pool.