Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize logging #1158

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Standardize logging #1158

wants to merge 8 commits into from

Conversation

rm-dr
Copy link
Contributor

@rm-dr rm-dr commented Feb 24, 2024

This PR replaces tectonic-status-base with tokio's tracing library. Addresses #1152.

The interesting commits are

  • 53daa91, which converts log calls to the new api;
  • and 3536977, which implements a new logger

This PR also changes the log-level cli option, replacing default and minimal with the fairly universal debug, info, warn and error log levels. (b9f0aa3)

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 48.72299% with 261 lines in your changes are missing coverage. Please review.

Project coverage is 46.35%. Comparing base (edd49ba) to head (e4e3c85).
Report is 4 commits behind head on master.

❗ Current head e4e3c85 differs from pull request most recent head b99cdd5. Consider uploading reports for the commit b99cdd5 to get more accurate results

Files Patch % Lines
crates/engine_spx2html/src/emission.rs 0.00% 40 Missing ⚠️
src/driver.rs 61.70% 36 Missing ⚠️
src/bin/tectonic/v2cli.rs 50.79% 31 Missing ⚠️
crates/bridge_core/src/lib.rs 38.77% 30 Missing ⚠️
crates/engine_spx2html/src/initialization.rs 0.00% 18 Missing ⚠️
crates/engine_spx2html/src/lib.rs 0.00% 13 Missing ⚠️
src/bin/tectonic/log.rs 70.45% 13 Missing ⚠️
crates/engine_spx2html/src/finalization.rs 0.00% 11 Missing ⚠️
crates/bundles/src/cache.rs 63.15% 7 Missing ⚠️
crates/engine_spx2html/src/fonts.rs 0.00% 7 Missing ⚠️
... and 15 more
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1158    +/-   ##
========================================
  Coverage   46.35%   46.35%            
========================================
  Files         171      169     -2     
  Lines       65136    64915   -221     
========================================
- Hits        30191    30093    -98     
+ Misses      34945    34822   -123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rm-dr rm-dr added dependencies Issues with crates we depend upon chore Minor cleanup, version bumps, etc cli Relevant to tectonic's command-line interface labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Minor cleanup, version bumps, etc cli Relevant to tectonic's command-line interface dependencies Issues with crates we depend upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant