Fixed handling of transparency in PDF/A mode in addExtGState method #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
williamdes
approved these changes
Mar 14, 2024
|
@nicolaasuni what do you think ? |
|
Please try to resolve the conflicts. |
The condition allowed to add ExtGState in all PDF/A modes and disallowed in default mode. This fix inlines the condition with setExtGState to allow transparency parameters for non-PDF/A and PDF/A > 1 documents. The state condition is copied from 'setExtGState'.
stollr
force-pushed
the
fix_pdfa_addExtGState
branch
from
2a36e6b
to
1056a31
Compare
|
@nicolaasuni I have rebased the PR on the main branch |
williamdes
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition allowed to add ExtGState in all PDF/A modes and disallowed it in default mode until now. This looks logically wrong.
This fix inlines the condition with setExtGState to allow transparency parameters for non-PDF/A and PDF/A > 1 documents.
The state condition is copied from 'setExtGState'.