fix: base64 images not rendered inside of html #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
williamdes
reviewed
Dec 1, 2023
williamdes
approved these changes
Dec 1, 2023
|
Please try to resolve the conflicts. |
compojoom
force-pushed
the
patch-1
branch
4 times, most recently
from
a31832a
to
605d0a1
Compare
williamdes
approved these changes
Apr 22, 2024
|
@williamdes I rebased. Sorry for the changelog change, but it seems you had an empty space and my IDE wants to remove it :) |
That's okay But can you remove the other commits? |
I'm not sure when this happened, but default base64 encoded images were no longer rendered in html text. If the image is rendered like this: ``` <img src="data:image/png;base64,....." /> ``` the image was not rendered when inside of an html text. Instead one has to replace `data:image/png;base64,` with `@`which in my opinion is not ideal and an overhead. tecnickcom#179 Update include/tcpdf_static.php Co-authored-by: William Desportes <williamdes@wdes.fr>
|
how about now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure when this happened, but default base64 encoded images were no longer rendered in html text.
If the image is rendered like this:
the image was not rendered when inside of an html text. Instead one has to replace
data:image/png;base64,with@which in my opinion is not ideal and an overhead.#179