New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: #553 #601
base: main
Are you sure you want to change the base?
Fix: #553 #601
Conversation
Leonardo Petrora seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
I have already signed the CLA but the status is still pending. I tried to recheck but there is no change |
Please edit the description to use |
@@ -7121,6 +7121,11 @@ public function Image($file, $x=null, $y=null, $w=0, $h=0, $type='', $link='', $ | |||
$mtd = '_parse'.$type; | |||
// GD image handler function | |||
$gdfunction = 'imagecreatefrom'.$type; | |||
|
|||
if ($type === 'png') { | |||
$gdfunction = '@' . $gdfunction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this cannot work - https://3v4l.org/lbu9o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the testing @mvorisek
This PR does not work correctly: #601 (comment)
to bypass this you have to add a helper variable like
but i have no idea if silencing a method was, is oder ever will be a good decision. |
Fix: #553