Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #553 #601

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: #553 #601

wants to merge 3 commits into from

Conversation

lpetrora
Copy link

@lpetrora lpetrora commented Mar 24, 2023

Fix: #553

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Leonardo Petrora seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lpetrora
Copy link
Author

I have already signed the CLA but the status is still pending. I tried to recheck but there is no change

@williamdes
Copy link
Contributor

Please edit the description to use Fixes: #553 or Fix: #553

@lpetrora lpetrora changed the title Fix #553 GD library error: imagecreatefrompng(): gd-png: libpng warning: iCCP: known incorrect sRGB profile Fix: #553 Mar 24, 2023
@@ -7121,6 +7121,11 @@ public function Image($file, $x=null, $y=null, $w=0, $h=0, $type='', $link='', $
$mtd = '_parse'.$type;
// GD image handler function
$gdfunction = 'imagecreatefrom'.$type;

if ($type === 'png') {
$gdfunction = '@' . $gdfunction;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this cannot work - https://3v4l.org/lbu9o

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the testing @mvorisek

This PR does not work correctly: #601 (comment)

@THenkeDE
Copy link

to bypass this you have to add a helper variable like

			$gdfunction = 'imagecreatefrom'.$type;
			$silenceGdfunction = $type === 'png';
			...
					// GD library
					$img = $silenceGdfunction ? @$gdfunction($file) : $gdfunction($file);

but i have no idea if silencing a method was, is oder ever will be a good decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD library error: imagecreatefrompng(): gd-png: libpng warning: iCCP: known incorrect sRGB profile
5 participants