Extract method to get TCPDF producer #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps TCPDF_STATIC::getTCPDFProducer() calls with a private method and adds an empty private property that can be used to change the producer line. The private property can be changed with the reflection API. Both method and property are declared as private to avoid BC breaks. The idea is to help with testing PDF generation, by using a predictable producer line. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 69.33% 69.32% -0.01%
==========================================
Files 128 128
Lines 27022 27027 +5
==========================================
+ Hits 18735 18737 +2
- Misses 8287 8290 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
williamdes
approved these changes
Dec 10, 2022
williamdes
approved these changes
Dec 17, 2022
ghost
approved these changes
May 12, 2023
|
@nicolaasuni could you review this one please ? |
Closed
|
The producer line is intentionally hardcoded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps
TCPDF_STATIC::getTCPDFProducer()calls with a private method and adds an empty private property that can be used to change the producer line. The private property can be changed with the reflection API.Both method and property are declared as private to avoid BC breaks.
The idea is to help with testing PDF generation, by using a predictable producer line.