Add automatic admittance emails after admitting users #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an admin admits a participant using the admin page, the application sends an automatic email to the admittee in a similar manner to the verification emails. This is done by using the email-link-action template in `server/emails/email-link-action/html.pug Also, fixed some spelling mistakes in the comments.
nadavsu
changed the title
nadavsu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When an admin admits users in the admin page, the application sends an automatic email to the admittees notifying them that they have been admitted to hackathon and that they should continue to the confirmation stage.
Motivation and Context
Before this PR, there was no way for the users to know that they have been admitted, unless they constantly checked their application status, or the admin has manually sent them an email notifying them about their application state.
This PR solves this issue by automatically sending an admittance email, notifying the participant that he/she has been admitted.
How Has This Been Tested
Was at first tested locally using a real email and gmail's smtp server.
Once tested thoroughly locally, this improvement was added to mtahack's fork (mtahack/quill@919fa1e) and worked without any bugs for 120 participants.
Tested on macOS and Windows locally.
Tested on Heroku.
Works even after confirming a user many times.
Screenshots
Screenshot of the confirmation email (with .env settings set to MTA Hack 2021)
Types of changes
Checklist
Also, fixed some spelling mistakes in the comments.