Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added Xcodegen and GitHub Action workflow for Carthage integration #379

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

philprime
Copy link
Member

  • refactor: moved public pagination structures to directory API
  • WIP
  • Removed schemes
  • Added shared scheme
  • WIP
  • WIP

@philprime philprime self-assigned this May 12, 2024
@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

SwiftLint found issues

Severity File Reason
Warning PDFPaginationStyle.swift:13 Line should be 150 characters or less: currently 151 characters (line_length)

Generated by 🚫 Danger Swift against 40a064e

@philprime philprime changed the title carthage xcodegen chore: added Xcodegen and GitHub Action workflow for Carthage integration May 12, 2024
@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against bf53227

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 185f255

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 76a9956

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 3f6c013

2 similar comments
@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 3f6c013

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 3f6c013

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 2bc6cb8

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 5a91fc1

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 1cbd5d8

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 6f0e2a8

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 434aced

@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can
⚠️ The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.

Generated by 🚫 Danger Swift against 50f1e42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants