Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency quick/quick to v7 #374

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependency quick/quick to v7 #374

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 5, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
Quick/Quick major 3.1.2 -> 7.5.0

Release Notes

Quick/Quick (Quick/Quick)

v7.5.0: - Pending tests are now marked as Skipped in Xcode

Compare Source

Highlights

  • Any tests which are pended-out (using pending, xdescribe, xcontext, xitBehavesLike, or xit), OR tests which are skipped because they are not focused (that is, the other tests when you use fdescribe, fcontext, fitBehavesLike or fit) are now marked as skipped in Xcode.

Automated Changelog

Full Changelog: Quick/Quick@v7.4.1...v7.5.0

v7.4.1

Compare Source

What's Changed

New Contributors

Full Changelog: Quick/Quick@v7.4.0...v7.4.1

v7.4.0: - visionOS support

Compare Source

Highlights

Autogenerated Release Notes

What's Changed

New Contributors

Full Changelog: Quick/Quick@v7.3.1...v7.4.0

v7.3.1

Compare Source

Highlights

  • Fixes a crash in AsyncSpec caused by race condition when unsetting AsyncSpec.current.

Autogenerated Release Notes

What's Changed

Full Changelog: Quick/Quick@v7.3.0...v7.3.1

v7.3.0

Compare Source

Highlights

  • Adds a property wrapper default initializer for TestState. Meaning the following declaration is now accepted!
@​TestState var foo: Int! = 30

Thanks @​tahirmt!

  • TestState now nils out the value after all afterEach blocks run, instead of in the middle of the afterEach chain. Thanks @​CraigSiemens

What's Changed

New Contributors

Full Changelog: Quick/Quick@v7.2.0...v7.3.0

v7.2.0: - TestState property wrapper

Compare Source

Highlight

You can now use the @TestState property wrapper to automatically deconstruct test variables. For example:

describe("using TestState") {
    @​TestState var subject: SomeObject?
}

Is functionally equivalent to:

describe("using TestState") {
    var subject: SomeObject?
    afterEach {
        subject = nil
    }
}

You can also specify an initial value, and TestState will act as an aroundEach: setting the wrapped variable to the value, then setting it to nil at test teardown.

describe("using TestState") {
    @​TestState(1) var value: Int?

    it("is already configured") {
        expect(value).to(equal(1))
    }
}

Thanks @​CraigSiemens for their contribution!

Automated Release Notes

What's Changed

Full Changelog: Quick/Quick@v7.1.0...v7.2.0

v7.1.0

Compare Source

Highlights

New Features

  • You can now use throw in beforeEach, justBeforeEach, and afterEach blocks.
  • Quick now suggests to XCTest that tests run in the order they are defined in.

Fixes

  • beforeEach blocks specified in configurations are now run in AsyncSpec tests.
  • xitBehavesLike(_ name: String) is now available in QuickSpec and Behavior.

Autogenerated ChangeLog

What's Changed

New Contributors

Full Changelog: Quick/Quick@v7.0.2...v7.1.0

v7.0.2

Compare Source

This is a bug fix release that primarily fixes a conflict in how Nimble defines FileString and how Quick defines FileString when you use both via Swift Package Manager. It also fixes a number of warnings people who install Quick via Swift Package Manager on Darwin will receive.

What's Changed

Full Changelog: Quick/Quick@v7.0.1...v7.0.2

v7.0.1: 7.0.1 - re-allow async calls in AsyncSpec's xit

Compare Source

This fixes an oversight where you couldn't use async closures with xit. Thanks @​stonko1994 for calling this out!

What's Changed

Full Changelog: Quick/Quick@v7.0.0...v7.0.1

v7.0.0: - AsyncSpec and Human-Readable Test Selectors

Compare Source

Highlights

Async Test Changes

Quick 7 changes how Async tests are run. Instead of forcing all tests to run in an async context, Quick 7 provides a separate Spec class for Async Tests. Create an AsyncSpec subclass, and all tests inside of that subclass will run in an async context. Tests inside of QuickSpec subclasses will have a similar behavior to what was in Quick 5.

Additionally, Quick 7 changes how the DSL is defined slightly. In Quick 6 and before, the DSL was defined as a series of global functions, available to be called anywhere. In Quick 7, these functions were moved to be static methods on the new SyncDSLUser (which QuickSpec, Behavior, and QuickConfiguration conform to) and AsyncDSLUser (which AsyncSpec and AsyncBehavior conform to) protocols. This allows us to make sure that you are using the correct DSL for the context, and was necessary for this approach.

For example:

class SynchronousSpec: QuickSpec {
    override class func spec() {
        it("runs synchronously, as you'd expect") {
            var ocean: [String] = []
            DispatchQueue.main.async {
                ocean.append("dolphins")
                ocean.append("whales")
            }
            expect(ocean).toEventually(contain("dolphins", "whales"))
        }
    }
}

actor OceanActor<T> {
    var contents: [T] = []
    func append(_ value: T) {
        contents.append(value)
    }
}

class AsynchronousSpec: AsyncSpec {
    override class func spec() {
        it("runs the test in an async context") {
            let ocean = OceanActor<String>()
            Task {
                await ocean.append("dolphins")
                await ocean.append("whales")
            }
            await expect { await ocean.contents }.toEventually(contain("dolphins", "whales"))
        }
    }
}

Unencoded Test Selectors

Furthermore, Quick 7 changes how test selectors are generated for QuickSpec. Now, both AsyncSpec and QuickSpec will use the unencoded test names as the test selectors. Test selectors are now generated by joining the describe/context blocks leading up to the it block with ", ". This makes test names immensely easier to read. For example, with the following spec:

class MySpec: QuickSpec {
    override class func spec() {
        describe("some feature") {
            context("in one case") {
                it("has a behavior") {}
            }

            context("in another case") {
                it("doesn't have the earlier behavior") {}
            }
        }
    }
}

will generate the following test selectors:

  • some feature, in one case, has a behavior
  • some feature, in another case, doesn't have the earlier behavior

You can disable this change by setting the QUICK_USE_ENCODED_TEST_SELECTOR_NAMES environment variable.

Migrating Suggestions

Quick 7 is not a drop-in migration from either Quick 5 or Quick 6. Quick 5 users will have a slightly easier time upgrading, but due to spec being defined as a class method instead of an instance method, there will still be changes.

Doing a Find & Replace of override func spec with override class func spec will take care of the low-hanging fruit. If you have any test helpers that exist as properties or methods of your QuickSpec subclasses, the you will need to either move them inside of the spec function, or outside to another scope. For Objective-C users, this is, for the most part, a drop-in replacement. You will only need to do anything if you do not use the QuickSpecBegin and QuickSpecEnd macros (in which case: do a find & replace of the regex -(\s*)\(void\)(\s*)spec with +$1(void)$2spec).

For migrating from Quick 6 to Quick 7, it would be easiest to also do a Find & Replace of : QuickSpec to : AsyncSpec, then migrate tests that do not need to run in async contexts to be QuickSpecs themselves.

Auto-Generated Changelog

What's Changed

New Contributors

Full Changelog: Quick/Quick@v6.1.0...v7.0.0

v6.1.0

Compare Source

Highlighted Changes

  • New TestState property wrapper (Thanks @​CraigSiemens!). You can now wrap properties with @TestState to have them automatically set to nil.
  • Objective-C API is no longer available in Swift, this should reduce confusion whether a test is being executed in an async context or not.
  • This release drops support for Swift 5.6/Xcode 13.3.1.

Auto-generated Release Notes

What's Changed

New Contributors

Full Changelog: Quick/Quick@v6.0.1...v6.1.0

v6.0.1

Compare Source

What's Changed

Full Changelog: Quick/Quick@v6.0.0...v6.0.1

v6.0.0

Compare Source

This closes the v6.0.0 milestone.

Highlights

See additional details under the auto-generated release notes below.

Fixed

New

var ordering: [Int] = []
beforeEach {
    ordering.append(1)
}

justBeforeEach {
    ordering.append(3)
}

beforeEach {
    ordering.append(2)
}

it("runs justBeforeEach after the other beforeEach's") {
    expect(ordering).to(equal([1, 2, 3]))
}

Breaking

  • This version raises minimum required version to Swift 5.6, and required OS to macOS 10.15, iOS 13, and tvOS 13.
  • aroundEach is removed from the Objective-C API https://github.com/Quick/Quick/pull/1160
  • Again, with the async support, all tests now run in an async context. This will require you to make changes, especially if you use Nimble.

Auto-Generated Release Notes

What's Changed

New Contributors

Full Changelog: Quick/Quick@v5.0.1...v6.0.0

v5.0.1

Compare Source

This release closes the v5.0.1 milestone.

What's Changed

Full Changelog: Quick/Quick@v5.0.0...v5.0.1

v5.0.0

Compare Source

This release closes the v5.0.0 milestone.

Highlights

See additional details under the auto-generated release notes below.

Fixed

New

Breaking

  • Rename Configuration -> QCKConfiguration #​1133
  • Make FilterFlags implementation detail #​1068

Auto-generated release notes

What's Changed

New Contributors

Full Changelog: Quick/Quick@v4.0.0...v5.0.0

v4.0.0

Compare Source

Quick v4 has been released! 🎉 The new major version requires Swift 5.2 / Xcode 11.4 at least.

BREAKING CHANGES

  • Bump minimum iOS version to 9.0 #​1013
  • Rename master branch to main #​1052

Changes

  • [CI] Test Xcode 12 and Swift 5.3 #​1010
  • Set ENABLE_TESTING_SEARCH_PATHS to YES #​1011
  • Upgrade Project Format to Xcode 11.4-compatible #​1012 (Thanks @​mRs-)
  • [CI] Use rake directly instead of travis-script-macos #​1019
  • Update Nimble to 9.1.0 #​1020, #​1062, #​1066
  • Xcode 12.0: Update to recommended settings #​1021
  • Address deprecation warnings in Xcode 12 #​1040
  • Migrate Linux CI from Travis to GitHub Actions #​1042
  • [CI] Use norionomura/swift Docker images for Linux CI #​1043
  • [SwiftLint] Enable yoda_condition rule #​1044
  • [CI] Use the official Swift Docker images #​1049
  • [CI] Split ci.yml into dedicated workflows #​1050
  • Tweak CI workflows regarding fkirc/skip-duplicate-actions and matrix testing #​1051
  • Xcode 12.5: Update to recommended settings #​1063
  • [CI] Update Xcode and Swift versions #​1064

Documentation Changes

Miscellaneous

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@techprimate-bot
Copy link

Warnings
⚠️ The Package.swift was updated, but there were no changes in TPPDF.podspec, Package.resolved. Did you forget to update them?

SwiftLint found issues

Severity File Reason
Warning Package.swift:9 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:12 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:16 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:23 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:25 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:30 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:32 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:33 Collection literals should not have trailing commas. (trailing_comma)

Generated by 🚫 Danger Swift against a9f9575

@philprime
Copy link
Member

Closed due to minimum platform requirements not backwards compatible

@philprime philprime closed this May 5, 2024
@renovate Renovate
Copy link
Contributor Author

renovate bot commented May 5, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 7.x releases. But if you manually upgrade to 7.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/quick-quick-7.x branch May 5, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🚀 automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@techprimate-bot @philprime