Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/improvements #370

Merged
merged 12 commits into from Apr 25, 2024
Merged

feature/improvements #370

merged 12 commits into from Apr 25, 2024

Conversation

philprime
Copy link
Member

  • feat: added NSBezierPath.cubicCurveTo and NSBezierPath.quadraticCurveTo
  • feat: added Xcode workspace for example projects
  • WIP

@philprime philprime self-assigned this Apr 22, 2024
@techprimate-bot
Copy link

Warnings
⚠️ Any changes to library code should be reflected in the Changelog. Please consider adding a note there.
⚠️ Big PR, try to keep changes smaller if you can

SwiftLint found issues

Severity File Reason
Warning TableOfContentsExampleFactory.swift:17 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning TableOfContentsExampleFactory.swift:16 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning TableOfContentsExampleFactory.swift:6 Header comments should be consistent with project patterns. (file_header)
Warning TableOfContentsExampleFactory.swift:50 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFDocument.swift:40 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFDocument.swift:43 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFDocument.swift:43 Declaration masterGroup contains the term "master" which is not considered inclusive. (inclusive_language)
Warning PDFDocument.swift:323 Declaration set(master:) contains the term "master" which is not considered inclusive. (inclusive_language)
Warning PDFGroupContainer.swift:27 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupContainer.swift:42 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupContainer.swift:47 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroup.swift:89 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroup.swift:111 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroup.swift:23 Line should be 150 characters or less: currently 166 characters (line_length)
Warning PDFMasterGroup.swift:19 Declaration PDFMasterGroup contains the term "master" which is not considered inclusive. (inclusive_language)
Warning PDFBezierPath.swift:46 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFBezierPath.swift:67 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFBezierPath.swift:70 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFBezierPath.swift:191 Function body should span 40 lines or less excluding comments and whitespace: currently spans 52 lines (function_body_length)
Warning PDFBezierPath.swift:103 Line should be 150 characters or less: currently 180 characters (line_length)
Warning PDFBezierPath.swift:116 Line should be 150 characters or less: currently 153 characters (line_length)
Warning PDFBezierPath.swift:119 Line should be 150 characters or less: currently 180 characters (line_length)
Warning PDFBezierPath.swift:140 Line should be 150 characters or less: currently 180 characters (line_length)
Warning PDFBezierPath.swift:159 Line should be 150 characters or less: currently 168 characters (line_length)
Warning PDFContainer.swift:46 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFContainer.swift:56 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFContainer.swift:66 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFContainer.swift:71 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFContainer.swift:81 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFContainer.swift:95 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFContainer.swift:99 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFList.swift:119 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFList.swift:126 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFList.swift:124 Lines should not have trailing whitespace. (trailing_whitespace)
Warning PDFListItemSymbol.swift:28 Line should be 150 characters or less: currently 180 characters (line_length)
Warning PDFListItemSymbol.swift:33 Line should be 150 characters or less: currently 164 characters (line_length)
Warning PDFInfo.swift:94 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFInfo.swift:101 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFGenerator.swift:24 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:27 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:30 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:33 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:39 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:42 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:45 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:61 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:70 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGenerator.swift:42 Declaration masterGroup contains the term "master" which is not considered inclusive. (inclusive_language)
Warning PDFSection.swift:65 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFSection.swift:20 Line should be 150 characters or less: currently 214 characters (line_length)
Warning PDFSection.swift:22 Line should be 150 characters or less: currently 214 characters (line_length)
Warning PDFSection.swift:35 Line should be 150 characters or less: currently 171 characters (line_length)
Warning PDFTableOfContent.swift:9 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableOfContent.swift:65 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableOfContent.swift:86 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableOfContent.swift:14 Line should be 150 characters or less: currently 160 characters (line_length)
Warning PDFGenerator+Generation.swift:213 Function should have complexity 10 or less: currently complexity equals 11 (cyclomatic_complexity)
Warning PDFGenerator+Generation.swift:84 Declaration masterObjects contains the term "master" which is not considered inclusive. (inclusive_language)
Warning PDFGenerator+Generation.swift:85 Declaration masterGroup contains the term "master" which is not considered inclusive. (inclusive_language)
Warning PDFGenerator+Generation.swift:224 Declaration hasAddedMasterToPage contains the term "master" which is not considered inclusive. (inclusive_language)
Warning PDFGenerator+Generation.swift:213 Declaration calculateRenderObjects(contentObjs:masterObj:progress:) contains the term "master" which is not considered inclusive. (inclusive_language)
Warning PDFGenerator+Generation.swift:204 Line should be 150 characters or less: currently 177 characters (line_length)
Warning PDFGenerator+Generation.swift:331 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFTableContent.swift:21 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:26 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:38 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:46 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:70 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:77 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:84 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:91 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:98 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableContent.swift:105 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFSectionColumn.swift:33 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFSectionColumn.swift:47 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFSimpleText+Equatable.swift:10 public declarations should be documented. (missing_docs)
Warning PDFTextStyle.swift:35 Line should be 150 characters or less: currently 155 characters (line_length)
Warning PDFConstants.swift:4 Types used for hosting only static members should be implemented as a caseless enum to avoid instantiation. (convenience_type)
Warning PDFConstants.swift:8 Line should be 150 characters or less: currently 179 characters (line_length)
Warning PDFDocumentObject.swift:23 Line should be 150 characters or less: currently 151 characters (line_length)
Warning PDFError.swift:37 Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
Warning CrossPlattformGraphics.swift:193 Closure body should span 20 lines or less excluding comments and whitespace: currently spans 25 lines (closure_body_length)
Warning CrossPlattformGraphics.swift:33 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning CrossPlattformGraphics.swift:66 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning CrossPlattformGraphics.swift:78 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning CrossPlattformGraphics.swift:87 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning CrossPlattformGraphics.swift:113 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning CrossPlattformGraphics.swift:121 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning CrossPlattformGraphics.swift:190 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning CrossPlattformGraphics.swift:231 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning CrossPlattformGraphics.swift:121 Function body should span 40 lines or less excluding comments and whitespace: currently spans 45 lines (function_body_length)
Warning CrossPlattformGraphics.swift:13 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:14 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:15 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:16 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:17 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:18 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:19 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:25 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:26 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:27 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:28 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:29 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:30 public declarations should be documented. (missing_docs)
Warning CrossPlattformGraphics.swift:48 public declarations should be documented. (missing_docs)
Warning PDFGroupObject.swift:20 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:25 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:30 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:35 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:40 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:45 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:50 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:55 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:60 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:81 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:201 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:257 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:16 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFGroupObject.swift:98 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFGenerator+Debug.swift:56 Line should be 150 characters or less: currently 154 characters (line_length)
Warning PDFGenerator+Debug.swift:65 Line should be 150 characters or less: currently 155 characters (line_length)
Warning PDFAttributedTextObject.swift:21 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:24 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:27 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:36 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:51 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:61 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:69 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:114 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:243 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:272 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:297 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:19 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFAttributedTextObject.swift:290 Collection literals should not have trailing commas. (trailing_comma)
Warning PDFError_Spec.swift:14 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFError_Spec.swift:13 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFError_Spec.swift:6 Header comments should be consistent with project patterns. (file_header)
Error PDFError_Spec.swift:13 Type name should only contain alphanumeric characters: 'PDFError_Spec' (type_name)
Warning PDFTableObject.swift:282 Function should have complexity 10 or less: currently complexity equals 12 (cyclomatic_complexity)
Warning PDFTableObject.swift:420 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableObject.swift:422 All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
Warning PDFTableObject.swift:620 File should contain 500 lines or less: currently contains 620 (file_length)
Warning PDFTableObject.swift:38 Function body should span 40 lines or less excluding comments and whitespace: currently spans 54 lines (function_body_length)
Warning PDFTableObject.swift:282 Function body should span 40 lines or less excluding comments and whitespace: currently spans 86 lines (function_body_length)
Warning PDFTableObject.swift:358 Line should be 150 characters or less: currently 156 characters (line_length)
Warning PDFTableObject.swift:434 Line should be 150 characters or less: currently 191 characters (line_length)
Warning PDFTableObject.swift:19 Type body should span 300 lines or less excluding comments and whitespace: currently spans 359 lines (type_body_length)
Warning PDFCalculations.swift:617 File should contain 500 lines or less: currently contains 617 (file_length)

Generated by 🚫 Danger Swift against 42d171e

@techprimate-bot
Copy link

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Swift against 73e902e

@techprimate-bot
Copy link

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Swift against 5ba0847

@techprimate-bot
Copy link

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Swift against 8167223

@philprime philprime merged commit 8167223 into main Apr 25, 2024
6 checks passed
@philprime philprime deleted the feature/improvements branch April 25, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants