Allowing use of GraphicsMagick as conversion tool #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for putting this together - caught your Velocity 2016 talk and was psyched to implement at my shop.
We're using GraphicsMagick over here so I added an option to use such. Not hung up on the implementation, just 'worked'.
I also pulled out the conversion to png and base64 for the input image from the while loop as it was unnecessary to do it on each iteration, shaving off a few ms.