fix: Don't submit locationSource on create site #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows me to create a site locally, and logically makes sense. However I'm not sure why Typescript does not pick up on this error.
david-code
force-pushed
the
fix/fix-input-to-site-creation
branch
from
01130bd
to
aa22a19
Compare
|
it's a longstanding TypeScript deficiency. at some point i tried to find a way to format our mutations to catch this kind of bug: techmatters/terraso-client-shared#45, but the fix i tried there wouldn't actually help with this case anyway 😫 |
shrouxm
approved these changes
Oct 3, 2023
Thanks for the link, that's interesting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows me to create a site locally, and logically makes sense. However I'm not sure why Typescript does not pick up on locationSource being included in the input to the GraphQL call here. @shrouxm any idea?
Description
Checklist
Related Issues
Fixes #....
Verification steps