Adding support for variables #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: radius+2 becomes (value of radius)+2 => 8.14+2 Currently variables only defined in code in main.js/known_variables
… because there were too much errors (Warnings, that prevent releasing). It's temporary but I don't know what else to do
…e of unclean working tree. I really don't understand this js stuff
This was referenced Dec 4, 2020
|
Hey @BastionInCzech |
|
Did some more last-minute testing, but I think it's okay at this stage. Coudln't find any more bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variables work by modifying the expression input. You have a dictionary known_variables. In it, you have key value pair of radius: 8.14 (for example).
Then if the expression is 2 + radius => 2 + 8.14 internally.
The result is 10.14. Declaring variables is also easy
"value = 50*2" Result of this is value of variable => 100
"value + 2" Result of this is 102
Sadly I had to modify more things.
I had to remove xo and npm lint from package.json because I was unable to build otherwise because of errors in last commit. I will happily change this if any of the maintainers tell me what to do about it.
I don't think it would be a good practice to change a lot of the code in a pull request because some errors are for example a wrong capitalization of a comment.