Add append method

team-acaisia · Apr 23, 2023 · b40acbd · b40acbd
1 parent a10bbae
commit b40acbd
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/src/ByteArray.php b/src/ByteArray.php
@@ -41,6 +41,14 @@ public static function fromArray(array $array): self
         return $self;
     }
 
+    public function append(ByteArray $array): self
+    {
+        foreach ($array->toArray() as $value) {
+            $this->array[] = $value;
+        }
+        return $this;
+    }
+
     /**
      * Create a byte array from string. Assumes every character in the string to be an unsigned char.
      */

diff --git a/tests/ByteArrayTest.php b/tests/ByteArrayTest.php
@@ -80,4 +80,25 @@ public static function provideString() : array
             ['🚀', [240, 159, 154, 128]], // This emoji should be 4 bytes (unicode)
         ];
     }
+
+    /**
+     * @dataProvider provideAppend
+     */
+    public function testAppend(ByteArray $current, ByteArray $appended, ByteArray $expected) : void
+    {
+        $this->assertEquals($current->append($appended), $expected);
+    }
+
+    public static function provideAppend() : array
+    {
+        return [
+            [ByteArray::fromArray([]), ByteArray::fromArray([]), ByteArray::fromArray([])], // 2x empty = empty
+            [ByteArray::fromArray([123]), ByteArray::fromArray([]), ByteArray::fromArray([123])],
+            [ByteArray::fromArray([]), ByteArray::fromArray([234]), ByteArray::fromArray([234])],
+
+            [ByteArray::fromArray([123]), ByteArray::fromArray([234]), ByteArray::fromArray([123, 234])],
+
+            [ByteArray::fromString('🚀'), ByteArray::fromString('🐸'), ByteArray::fromString('🚀🐸')],
+        ];
+    }
 }