-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples #651
Add examples #651
Conversation
Teal Playground URL: https://651--teal-playground-preview.netlify.app |
Hi! Thanks for the initiative! I wouldn't mind at all having some examples in the repo. My immediate thought goes towards long-term maintenance, though, so there are a few things that I'd like to see:
Apart from those items which I'd consider more-or-less blockers, there are other minor stylistic things that I'd probably change:
Another possible avenue for learning-Teal-by-example would be to have larger well-commented examples added to the https://github.com/teal-language/teal-playground/ dropdown at https://teal-playground.netlify.app! |
Thanks for the thoughtful reply and your consideration of my offer. I'll make an attempt to update according to your feedback over the next 2 days. |
I think this latest update covers all but one of the bullet items you had. I do not know how to do the CI integration of the example code. |
@JLPLabs sorry it took me a long time to properly get to this. I have merged it manually, squashing the commits, removing the PNG file and reworking the example a bit (I made my changes on a separate commit for ease of diffing — should make it a lot easier to see what kind of changes I had in mind to get this merged; I thought I'd take the time and do them myself instead of asking for more changes). But it's merged now! So I'll close this PR manually. Thanks again!! |
Perhaps you will find value in adding examples for new users? I'm interested in preparing a handful of such examples, and have included this pull request to demonstrate what "Examples" could look like.