Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally loosen strictness for certain fields #11

Merged
merged 4 commits into from Jan 7, 2024
Merged

Optionally loosen strictness for certain fields #11

merged 4 commits into from Jan 7, 2024

Conversation

tdsmith
Copy link
Owner

@tdsmith tdsmith commented Jan 7, 2024

Meet Manager fairly regards certain fields as optional which are listed as M1 in the published spec. We should support serializing and deserializing SDIF files where these values are absent.

Adds a new strict mode that requires we match the spec exactly, which is off by default. Notes on the RelayName model that these fields are Optional even though they're "m1".

Fixes #9.

@tdsmith
Copy link
Owner Author

tdsmith commented Jan 7, 2024

@ericvsmith I took a swing at it. I'll go ahead and cut a release for the sake of expediency, but let me know if you need something different here!

@tdsmith tdsmith merged commit 7ab7c6b into main Jan 7, 2024
3 checks passed
@tdsmith tdsmith deleted the unstrict branch January 7, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to skip required fields?
1 participant