Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds different swap message based on trade type #505

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

bordalix
Copy link
Contributor

Closes #504

Today the dashboard doesn't inform about the swap/trade type, which can be:

  • BUY = buy the base asset, sell quote asset
  • SELL = sell the base asset, buy quote asset

With this PR, the order of the coins logos and the message for each swap changes based on the trade type:

  • BUY = swap quote asset for base asset
  • SELL = swap base asset for quote asset

@tiero please review

@tiero
Copy link
Contributor

tiero commented Aug 29, 2023

@altafan after merge let's release it and bump to umbrel

@Janaka-Steph Janaka-Steph merged commit b16bf18 into tdex-network:v1 Aug 29, 2023
1 check passed
Copy link
Collaborator

@Janaka-Steph Janaka-Steph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect display of base and quote asset in dashboard
3 participants